From: Mark Brown <broonie@kernel.org>
To: linuxkernel@fbautosys.co.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/5] regmap: Add Parity bit Calculation to regmaps
Date: Mon, 20 Dec 2021 14:05:04 +0000 [thread overview]
Message-ID: <YcCNkCPzhyWm5YE3@sirena.org.uk> (raw)
In-Reply-To: <20211217224104.1747758-2-linuxkernel@fbautosys.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Fri, Dec 17, 2021 at 10:41:00PM +0000, linuxkernel@fbautosys.co.uk wrote:
> From: Christopher Tyerman <c.tyerman@firebladeautomationsystems.co.uk>
>
> regmap.h
>
> Added parity_read_mask to regmap_config
> Added parity_write_mask to regmap_config
> Added (*parity_calc)() to regmap_config
>
> Added regmap_parity_calc_even() Added regmap_parity_calc_odd()
>
> internal.h
>
> Added parity_read_mask to regmap
> Added parity_write_mask to regmap
> Added (*parity_calc) to regmap
>
> regmap.c
> Altered _regmap_raw_write_impl() to calculate parity
> Altered _regmap_raw_read() to calculate parity
> Added regmap_set_work_buf_parity_mask()
> Added regmap_parity_calc_even()
> Added regmap_parity_calc_odd()
> Added parity_even()
> Added parity16_even(u16 v)
> Added parity32_even(u32 v)
> Added parity64_even(u64 v)
This isn't a good changelog, the changelog needs to describe what is
being changed in the code and why in a way that provides information to
the human reader. Instead this is essentially a list of code level
changes in the diff. There's some advice on changelogs in
submitting-patches.rst. Without a clear changelog it's hard to review
things as it's not clear what the goals are.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-20 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 22:40 [RFC PATCH 0/5] regmap: Add Parity bit Calculation to regmaps linuxkernel
2021-12-17 22:41 ` [RFC PATCH 1/5] " linuxkernel
2021-12-20 14:05 ` Mark Brown [this message]
2021-12-17 22:41 ` [RFC PATCH 2/5] regmap: Altered regmap_X_X_write functions to account for padding bits linuxkernel
2021-12-17 22:41 ` [RFC PATCH 3/5] regmap: Added setting of writemap to formatted write linuxkernel
2021-12-17 22:41 ` [RFC PATCH 4/5] regmap: Add Parity Calculation " linuxkernel
2021-12-17 22:41 ` [RFC PATCH 5/5] regmap: Add parser for X_9 formats linuxkernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcCNkCPzhyWm5YE3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxkernel@fbautosys.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox