Re: [PATCH v5 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver

Rob Herring
2021-12-13T17:27:00Z

On Mon, Dec 13, 2021 at 03:10:06PM +0800, Hammer Hsieh wrote:
> Add bindings doc for Sunplus SoC UART Driver
>
> Signed-off-by: Hammer Hsieh <hammer.hsieh@sunplus.com>
> ---
> Changes in v4:
> - no change.
> - Reviewed-by : Rob Herring <robh@kernel.org> in v3.

That goes above your Signed-off-by.

>
> Changes in v5:
> - remove another two author's name, the whole driver already quite different compared
> with patch v1. The other two authors request me to remove it.
>
> .../bindings/serial/sunplus,sp7021-uart.yaml | 56 ++++++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> new file mode 100644
> index 0000000..ab66a0f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
> +
> +maintainers:
> + - Hammer Hsieh <hammer.hsieh@sunplus.com>
> +
> +allOf:
> + - $ref: serial.yaml#
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + aliases {
> + serial0 = &uart0;
> + };
> +
> + uart0: serial@9c000900 {
> + compatible = "sunplus,sp7021-uart";
> + reg = <0x9c000900 0x80>;
> + interrupt-parent = <&intc>;
> + interrupts = <53 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clkc 0x28>;
> + resets = <&rstc 0x18>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3b79fd4..f2ee40c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17945,6 +17945,11 @@ L: netdev@vger.kernel.org
> S: Maintained
> F: drivers/net/ethernet/dlink/sundance.c
>
> +SUNPLUS UART DRIVER
> +M: Hammer Hsieh <hammer.hsieh@sunplus.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> +
> SUPERH
> M: Yoshinori Sato <ysato@users.sourceforge.jp>
> M: Rich Felker <dalias@libc.org>
> --
> 2.7.4
>
>