From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: ok@artecdesign.ee, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] USB: host: isp116x: Check for null res pointer
Date: Tue, 21 Dec 2021 07:17:02 +0100 [thread overview]
Message-ID: <YcFxXkn99IOl2L3s@kroah.com> (raw)
In-Reply-To: <20211221015658.1002191-1-jiasheng@iscas.ac.cn>
On Tue, Dec 21, 2021 at 09:56:58AM +0800, Jiasheng Jiang wrote:
> And I correct my commit message because platform_get_resource returns
> null if fails.
> Here is it.
> The return value of platform_get_resource() could be null when there is
> no suitable resource.
> So it should be better to check it to avoid the use of null pointer in
> release_mem_region().
>
> Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v3 -> v4
>
> *Change 1. Just skip the use of null pointer instead of directly return.
> *Change 2. Add the driver name in the subject line.
> *Change 3. Correct commit message.
> ---
> drivers/usb/host/isp116x-hcd.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
*plonk*
prev parent reply other threads:[~2021-12-21 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 1:56 [PATCH v4] USB: host: isp116x: Check for null res pointer Jiasheng Jiang
2021-12-21 6:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcFxXkn99IOl2L3s@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ok@artecdesign.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox