* [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static
@ 2021-12-19 9:14 Quanfa Fu
2021-12-21 16:15 ` Sean Christopherson
2022-01-24 14:18 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Quanfa Fu @ 2021-12-19 9:14 UTC (permalink / raw)
To: pbonzini, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
mingo, bp, dave.hansen, hpa
Cc: x86, linux-kernel, Quanfa Fu
Make kvm_vcpu_reload_apic_access_page() static
as it is no longer invoked directly by vmx
and it is also no longer exported.
No functional change intended.
Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
---
arch/x86/include/asm/kvm_host.h | 1 -
arch/x86/kvm/x86.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 2164b9f4c7b0..f1c4ba208ed6 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1855,7 +1855,6 @@ int kvm_cpu_has_extint(struct kvm_vcpu *v);
int kvm_arch_interrupt_allowed(struct kvm_vcpu *vcpu);
int kvm_cpu_get_interrupt(struct kvm_vcpu *v);
void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event);
-void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu);
int kvm_pv_send_ipi(struct kvm *kvm, unsigned long ipi_bitmap_low,
unsigned long ipi_bitmap_high, u32 min,
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 0cf1082455df..6569a62ea38b 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -9621,7 +9621,7 @@ void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
kvm_make_all_cpus_request(kvm, KVM_REQ_APIC_PAGE_RELOAD);
}
-void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
+static void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
{
if (!lapic_in_kernel(vcpu))
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static
2021-12-19 9:14 [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static Quanfa Fu
@ 2021-12-21 16:15 ` Sean Christopherson
2022-01-24 14:18 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2021-12-21 16:15 UTC (permalink / raw)
To: Quanfa Fu
Cc: pbonzini, vkuznets, wanpengli, jmattson, joro, tglx, mingo, bp,
dave.hansen, hpa, x86, linux-kernel
On Sun, Dec 19, 2021, Quanfa Fu wrote:
> Make kvm_vcpu_reload_apic_access_page() static
> as it is no longer invoked directly by vmx
> and it is also no longer exported.
Nit, in the future, please wrap closer to 75 chars, there's no need for this to
be spread out over three lines, e.g.
Make kvm_vcpu_reload_apic_access_page() static as it is no longer invoked
directly by vmx and it is also no longer exported.
> No functional change intended.
>
> Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static
2021-12-19 9:14 [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static Quanfa Fu
2021-12-21 16:15 ` Sean Christopherson
@ 2022-01-24 14:18 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2022-01-24 14:18 UTC (permalink / raw)
To: Quanfa Fu, seanjc, vkuznets, wanpengli, jmattson, joro, tglx,
mingo, bp, dave.hansen, hpa
Cc: x86, linux-kernel
On 12/19/21 10:14, Quanfa Fu wrote:
> Make kvm_vcpu_reload_apic_access_page() static
> as it is no longer invoked directly by vmx
> and it is also no longer exported.
>
> No functional change intended.
>
> Signed-off-by: Quanfa Fu <quanfafu@gmail.com>
> ---
> arch/x86/include/asm/kvm_host.h | 1 -
> arch/x86/kvm/x86.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 2164b9f4c7b0..f1c4ba208ed6 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1855,7 +1855,6 @@ int kvm_cpu_has_extint(struct kvm_vcpu *v);
> int kvm_arch_interrupt_allowed(struct kvm_vcpu *vcpu);
> int kvm_cpu_get_interrupt(struct kvm_vcpu *v);
> void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event);
> -void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu);
>
> int kvm_pv_send_ipi(struct kvm *kvm, unsigned long ipi_bitmap_low,
> unsigned long ipi_bitmap_high, u32 min,
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 0cf1082455df..6569a62ea38b 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9621,7 +9621,7 @@ void kvm_arch_mmu_notifier_invalidate_range(struct kvm *kvm,
> kvm_make_all_cpus_request(kvm, KVM_REQ_APIC_PAGE_RELOAD);
> }
>
> -void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> +static void kvm_vcpu_reload_apic_access_page(struct kvm_vcpu *vcpu)
> {
> if (!lapic_in_kernel(vcpu))
> return;
Queued, thanks.
paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-24 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-19 9:14 [PATCH] KVM/X86: Make kvm_vcpu_reload_apic_access_page() static Quanfa Fu
2021-12-21 16:15 ` Sean Christopherson
2022-01-24 14:18 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox