From: Borislav Petkov <bp@suse.de>
To: Marco Elver <elver@google.com>
Cc: Carel Si <beibei.si@intel.com>,
"Yin, Fengwei" <fengwei.yin@intel.com>,
Joerg Roedel <jroedel@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"lkp@lists.01.org" <lkp@lists.01.org>, lkp <lkp@intel.com>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV?
Date: Tue, 21 Dec 2021 16:22:19 +0100 [thread overview]
Message-ID: <YcHxKzB3WPurKlZ9@zn.tnic> (raw)
In-Reply-To: <CANpmjNO4hs1B9eDY9edGGOXY45a8smdtYfYfbDRnGWSYch4wGg@mail.gmail.com>
On Tue, Dec 21, 2021 at 04:10:31PM +0100, Marco Elver wrote:
> Also double-check the Makefile-based solution: the Makefiles in both
> directories already contain various KCOV_INSTRUMENT/K*SAN_SANITIZE :=
> n, so perhaps adding GCOV_PROFILE or GCOV_PROFILE_whicheverfile.o := n
> may be more appropriate should the functions that should not be
> instrumented be a moving target, and prone to breakage again in
> future.
Yeah, I asked whether we should exclude the whole ...cpu/common.c from
profiling - it has mostly init code so it probably doesn't matter
for coverage but no one said anything so I left it to the function
annotation.
And also, I'm still waiting on clang folks to chime in on the New Pass
Manager and whether there's a bug in clang there so that we won't need
the __no_profile annotation at all. I mean, gcc is fine with that config
so unless clang is doing more profiling gunk than gcc and requires that
__llvm_gcov_init constructor... see Nathan's mail upthread.
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Ivo Totev, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2021-12-21 15:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:41 [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage kernel test robot
2021-12-14 16:38 ` Borislav Petkov
2021-12-15 7:00 ` [LKP] " Carel Si
2021-12-15 10:05 ` Borislav Petkov
2021-12-16 7:04 ` Yin Fengwei
2021-12-16 10:06 ` Borislav Petkov
2021-12-16 11:58 ` Carel Si
2021-12-16 12:21 ` Yin Fengwei
2021-12-17 12:52 ` [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV? Borislav Petkov
2021-12-17 18:04 ` Nathan Chancellor
2021-12-18 11:00 ` Borislav Petkov
2021-12-20 11:00 ` [PATCH] x86/mm: Prevent early boot triple-faults with instrumentation Borislav Petkov
2021-12-18 10:39 ` [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV? Yin Fengwei
2021-12-18 11:01 ` Borislav Petkov
2021-12-20 1:51 ` Yin Fengwei
2021-12-21 14:31 ` Carel Si
2021-12-21 15:10 ` Marco Elver
2021-12-21 15:22 ` Borislav Petkov [this message]
2022-01-05 2:35 ` Yin Fengwei
2022-01-05 11:36 ` Borislav Petkov
2022-01-05 12:47 ` Yin Fengwei
2022-01-05 15:21 ` Borislav Petkov
2022-01-06 6:56 ` Yin Fengwei
2021-12-21 15:14 ` Borislav Petkov
2021-12-22 10:59 ` [tip: x86/mm] x86/mm: Prevent early boot triple-faults with instrumentation tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcHxKzB3WPurKlZ9@zn.tnic \
--to=bp@suse.de \
--cc=beibei.si@intel.com \
--cc=bfields@fieldses.org \
--cc=elver@google.com \
--cc=fengwei.yin@intel.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox