From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0845C433EF for ; Tue, 21 Dec 2021 20:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233992AbhLUUL7 (ORCPT ); Tue, 21 Dec 2021 15:11:59 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37708 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233679AbhLUULz (ORCPT ); Tue, 21 Dec 2021 15:11:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=H6WiCsTBF0Mj/1BBGZ/QIUoU5L9v1U+PUEzb9y+rAB0=; b=0JmHQtMJckzi8OSsuRaLuYpt2w x5Co1tuRleJeA5OrFjM+YPITSPNuUM8p8CdXqx7BaPqZVNZVq7SE24Uy7dt6PJPQNNTV/kBLuc45p U8HZ/cwUk4+bQE9l03UbOoiwb/IjCFBvHh+jiMGMbM8xP9cBPEt5uh4mQNq3aJm4yrsY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mzlUE-00HAIG-08; Tue, 21 Dec 2021 21:11:50 +0100 Date: Tue, 21 Dec 2021 21:11:49 +0100 From: Andrew Lunn To: Pavel Skripkin Cc: davem@davemloft.net, kuba@kernel.org, linux@rempel-privat.de, robert.foss@collabora.com, freddy@asix.com.tw, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] asix: fix wrong return value in asix_check_host_enable() Message-ID: References: <8966e3b514edf39857dd93603fc79ec02e000a75.1640117288.git.paskripkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 21, 2021 at 11:10:43PM +0300, Pavel Skripkin wrote: > If asix_read_cmd() returns 0 on 30th interation, 0 will be returned from > asix_check_host_enable(), which is logically wrong. Fix it by returning > -ETIMEDOUT explicitly if we have exceeded 30 iterations > > Also, replaced 30 with #define as suggested by Andrew > > Fixes: a786e3195d6a ("net: asix: fix uninit value bugs") > Reported-by: Andrew Lunn > Signed-off-by: Pavel Skripkin Reviewed-by: Andrew Lunn Andrew