* [PATCH] staging: pi433: add comment to rx_lock mutex definition
@ 2021-12-22 9:36 Paulo Miguel Almeida
2021-12-22 9:41 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Paulo Miguel Almeida @ 2021-12-22 9:36 UTC (permalink / raw)
To: gregkh, realwakka, paulo.miguel.almeida.rodenas
Cc: linux-staging, linux-kernel
Checkpatch reports: CHECK: struct mutex definition without comment.
Fix this by documenting what rx_mutex struct is used for in pi433 driver.
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 29bd37669059..aa0ecb3788c6 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -92,6 +92,7 @@ struct pi433_device {
u32 rx_bytes_to_drop;
u32 rx_bytes_dropped;
unsigned int rx_position;
+ /* rx read and config operations can only be served one at the time */
struct mutex rx_lock;
wait_queue_head_t rx_wait_queue;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: pi433: add comment to rx_lock mutex definition
2021-12-22 9:36 [PATCH] staging: pi433: add comment to rx_lock mutex definition Paulo Miguel Almeida
@ 2021-12-22 9:41 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-12-22 9:41 UTC (permalink / raw)
To: Paulo Miguel Almeida; +Cc: realwakka, linux-staging, linux-kernel
On Wed, Dec 22, 2021 at 10:36:26PM +1300, Paulo Miguel Almeida wrote:
> Checkpatch reports: CHECK: struct mutex definition without comment.
> Fix this by documenting what rx_mutex struct is used for in pi433 driver.
>
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 29bd37669059..aa0ecb3788c6 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -92,6 +92,7 @@ struct pi433_device {
> u32 rx_bytes_to_drop;
> u32 rx_bytes_dropped;
> unsigned int rx_position;
> + /* rx read and config operations can only be served one at the time */
What exactly does this mean? What is this protecting? This comment
doesn't seem to be explaining much :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-22 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-22 9:36 [PATCH] staging: pi433: add comment to rx_lock mutex definition Paulo Miguel Almeida
2021-12-22 9:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox