linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kernel test robot <oliver.sang@intel.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, lkp@lists.01.org, lkp@intel.com
Subject: Re: [x86/entry_32]  aa93e2ad74: BUG:soft_lockup-CPU##stuck_for#s![systemd-logind:#]
Date: Wed, 12 Jan 2022 16:14:19 +0000	[thread overview]
Message-ID: <Yd7+W1gFbkBs5Lkd@google.com> (raw)
In-Reply-To: <Yd6ssarpDknV1r9z@hirez.programming.kicks-ass.net>

On Wed, Jan 12, 2022, Peter Zijlstra wrote:
> On Wed, Jan 12, 2022 at 01:28:58AM +0000, Sean Christopherson wrote:
> > The issue is that PARANOID_EXIT_TO_KERNEL_MODE in the handle_exception_return
> > path overwrites the entry stack data with the task stack data, restoring the "bad"
> > segment value.
> 
> Oh gawd... that's terrible, and yes, that now makes perfect sense.
> 
> However did you find that?

printf and running under QEMU, which has a interactive "monitor" that lets you
read/write guest memory and can also do VA=>PA translations.  Code inspection
once I realized the value on the stack was being restored between the exception
fixup and the POP.

  reply	other threads:[~2022-01-12 16:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06  8:35 [x86/entry_32] aa93e2ad74: BUG:soft_lockup-CPU##stuck_for#s![systemd-logind:#] kernel test robot
2022-01-11 11:11 ` Peter Zijlstra
2022-01-12  1:28   ` Sean Christopherson
2022-01-12 10:25     ` Peter Zijlstra
2022-01-12 16:14       ` Sean Christopherson [this message]
2022-01-12 10:55     ` [PATCH] x86/entry_32: Fix segment exceptions Peter Zijlstra
2022-01-12 15:42       ` Borislav Petkov
2022-01-13 18:54         ` Andy Lutomirski
2022-01-13 19:55           ` Peter Zijlstra
2022-01-14 11:24             ` Borislav Petkov
2022-01-14 23:48               ` Andy Lutomirski
2022-01-15  8:13                 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd7+W1gFbkBs5Lkd@google.com \
    --to=seanjc@google.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).