Re: [RFC PATCH v2 00/13] module: core code clean up

Aaron Tomlin
2022-01-12T13:21:13Z

On Tue 2022-01-11 17:16 -0800, Allen wrote:
> Hi Aaron,

Hi Allen,

> Was the code compile tested?

Not entirely i.e. not the whole of kernel/module/Makefile, unfortunately.
Furthermore, only x86-64 was compiled tested. At the moment, I felt the
need to share the concept/or approach thus far to simply obtain some
overall feedback before further modifications.

> Unfortunately, I could not apply the series cleanly on top of the
> latest 5.17-rc1.

Sorry about that: this work was based on Linus' commit 81361b837a34 ("Merge
tag 'kbuild-v5.14' of
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.").

> I did rebase the patches and fixed minor compile time failures as
> well a few small checkpatch errors.
> I have pushed the series to
> https://github.com/allenpais/Linux/commits/refactor_module_v3
> [The series now is based on
> 84bfcc0b6994 2022-01-11 Merge tag 'integrity-v5.17' of
> git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity]

Thanks for that. I'll have a look shortly to incorporate into RFC PATCH v3.

> So far I could only manage to compile test the patches. Will test it
> on BM(x86/arm) in a day or two.

Much appreciated.

Kind regards,

--
Aaron Tomlin