From: Mark Brown <broonie@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, Watson Chow <watson.chow@avnet.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulators: Add bindings for Maxim MAX20086-MAX20089
Date: Tue, 4 Jan 2022 14:49:48 +0000 [thread overview]
Message-ID: <YdRejDRYwoQbNY4f@sirena.org.uk> (raw)
In-Reply-To: <YdRdAI4S0+85CuDy@pendragon.ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Tue, Jan 04, 2022 at 04:43:12PM +0200, Laurent Pinchart wrote:
> On Tue, Jan 04, 2022 at 02:26:45PM +0000, Mark Brown wrote:
> > On Sun, Jan 02, 2022 at 11:11:23PM +0200, Laurent Pinchart wrote:
> > > + required:
> > > + - OUT1
> > > + - OUT2
> > Why are we requiring that there be machine constraints for the
> > individual regulators? There's already a problem with people just
> > using the maximum possible control a regulator has as the default for
> > devices without regard to what the specific system can support.
> Could you elaborate a bit, keeping in mind that I'm a newbie when it
> comes to the regulator framework ? :-)
Not really... the question is why we are marking these as required
rather than just letting them be omitted as we normally do for
individual regulators on a device. What purpose does it serve?
> How should I modify the DT bindings to match that correctly ?
Remove the required:.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-04 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 21:11 [PATCH 0/2] regulator: Add driver for Maxim MAX20086-MAX20089 Laurent Pinchart
2022-01-02 21:11 ` [PATCH 1/2] dt-bindings: regulators: Add bindings " Laurent Pinchart
2022-01-04 14:26 ` Mark Brown
2022-01-04 14:43 ` Laurent Pinchart
2022-01-04 14:49 ` Mark Brown [this message]
2022-01-02 21:11 ` [PATCH 2/2] regulator: Add MAX20086-MAX20089 driver Laurent Pinchart
2022-01-04 14:16 ` Mark Brown
2022-01-04 14:33 ` Laurent Pinchart
2022-01-04 14:47 ` Mark Brown
2022-01-05 23:07 ` Laurent Pinchart
2022-01-05 23:23 ` Laurent Pinchart
2022-01-06 11:40 ` Mark Brown
2022-01-05 6:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdRejDRYwoQbNY4f@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=watson.chow@avnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox