From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Landley <rob@landley.net>
Cc: linux-kernel@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: sq: use default_groups in kobj_type
Date: Wed, 5 Jan 2022 19:13:22 +0100 [thread overview]
Message-ID: <YdXfwnAnAvrcTQhk@kroah.com> (raw)
In-Reply-To: <616fabc9-cf79-4c84-a1cc-6ecede77fa9c@landley.net>
On Wed, Jan 05, 2022 at 12:11:25PM -0600, Rob Landley wrote:
> On 1/5/22 11:52 AM, Greg Kroah-Hartman wrote:
> > On Wed, Jan 05, 2022 at 11:46:28AM -0600, Rob Landley wrote:
> >> On 1/4/22 10:22 AM, Greg Kroah-Hartman wrote:
> >> > There are currently 2 ways to create a set of sysfs files for a
> >> > kobj_type, through the default_attrs field, and the default_groups
> >> > field. Move the sh sq sysfs code to use default_groups field which has
> >> > been the preferred way since aa30f47cf666 ("kobject: Add support for
> >> > default attribute groups to kobj_type") so that we can soon get rid of
> >> > the obsolete default_attrs field.
> >>
> >> Let's see, sh4-specific, depends on CONFIG_SH_STORE_QUEUES... it built but I'm
> >> not finding an "sq" entry under /proc. (Or anything with "mapping" in it...)
> >>
> >> Oh well, probably right? Didn't break anything for me:
> >>
> >> Tested-by: Rob Landley <rob@landley.net>
> >
> > Thanks! Seems to pass 0-day testing as well :)
> >
> > Should I take this in my tree?
>
> Yes please.
Wonderful, will go do that now.
greg k-h
prev parent reply other threads:[~2022-01-05 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 16:22 [PATCH] sh: sq: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-05 17:46 ` Rob Landley
2022-01-05 17:52 ` Greg Kroah-Hartman
2022-01-05 18:11 ` Rob Landley
2022-01-05 18:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdXfwnAnAvrcTQhk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rob@landley.net \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).