public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Cc: benh@amazon.com, jonas@southpole.se, kuni1840@gmail.com,
	linux-kernel@vger.kernel.org, openrisc@lists.librecores.org,
	stefan.kristiansson@saunalahti.fi
Subject: Re: [PATCH] openrisc/boot: Remove unnecessary initialisation in memcpy().
Date: Mon, 24 Jan 2022 09:45:43 +0900	[thread overview]
Message-ID: <Ye32t5ZccUwfa+ag@antec> (raw)
In-Reply-To: <20220124000249.4295-1-kuniyu@amazon.co.jp>

On Mon, Jan 24, 2022 at 09:02:49AM +0900, Kuniyuki Iwashima wrote:
> From:   Stafford Horne <shorne@gmail.com>
> Date:   Mon, 24 Jan 2022 08:27:54 +0900
> > On Sun, Jan 23, 2022 at 11:01:00AM +0900, Kuniyuki Iwashima wrote:
> > > 'd' and 's' are initialised later with 'dest_w' and 'src_w', so we need not
> > > initialise them before that.
> > > 
> > > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> > 
> > This looks fine to me.  I will queue this for the next release.
> 
> Thank you.
> 
> 
> > 
> > Just curious why are you working on OpenRISC?
> 
> While reading memcpy() variants, I found a nit to fix in x86 boot-time
> memcpy() [0].  While I'm at it, I just started reading all arch ones ;)
> 
> [0]: https://lore.kernel.org/lkml/20220123015807.45005-1-kuniyu@amazon.co.jp/

Got it.

Thanks again!

      reply	other threads:[~2022-01-24  0:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-23  2:01 [PATCH] openrisc/boot: Remove unnecessary initialisation in memcpy() Kuniyuki Iwashima
2022-01-23 23:27 ` Stafford Horne
2022-01-24  0:02   ` Kuniyuki Iwashima
2022-01-24  0:45     ` Stafford Horne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye32t5ZccUwfa+ag@antec \
    --to=shorne@gmail.com \
    --cc=benh@amazon.com \
    --cc=jonas@southpole.se \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@amazon.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openrisc@lists.librecores.org \
    --cc=stefan.kristiansson@saunalahti.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox