From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218C9C41535 for ; Mon, 24 Jan 2022 23:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2360273AbiAXXgW (ORCPT ); Mon, 24 Jan 2022 18:36:22 -0500 Received: from mail.skyhub.de ([5.9.137.197]:50958 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383911AbiAXWs2 (ORCPT ); Mon, 24 Jan 2022 17:48:28 -0500 Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C90FE1EC02DD; Mon, 24 Jan 2022 23:48:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643064502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=i3ynX/3WyXL+RIfj1UToTdc8PkhLwkgiGCcTadCCkMY=; b=gVtVcine7JJA4nWZ+l9gsKrWP0huJ2VGNVQQM0s7mdqyMK59z8o2N0Nzb+TN11jeCU94hU X13uUgORFoSIl82EqnY2FEOi5hl+y+z8NWtImSFyRCxA3jOQaK8vSx6nUKxFEpyYjm/Ezo XVkIoGU6T74ygiaQTqTcVX992KuTtow= Date: Mon, 24 Jan 2022 23:48:17 +0100 From: Borislav Petkov To: Kuniyuki Iwashima Cc: dave.hansen@intel.com, benh@amazon.com, dave.hansen@linux.intel.com, kuni1840@gmail.com, linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org Subject: Re: [PATCH] x86/boot: Avoid redundant address overlap tests in memcpy(). Message-ID: References: <20220124221447.1030-1-kuniyu@amazon.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220124221447.1030-1-kuniyu@amazon.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2022 at 07:14:47AM +0900, Kuniyuki Iwashima wrote: > > Also, is this worth the churn? It probably saves less than 10 > > instructions, all of which are ridiculously cheap. Is there a *reason* > > for this other than being a pure cleanup? > > This is just for cleanup. Was wondering the same thing, whether this is even worth the trouble. I'm sure you can find real bugs to fix. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette