Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

Michael Ellerman
2010-04-21T00:21:42Z

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Wed, 2010-04-21 at 18:55 +0300, Alexey Dobriyan wrote:
> On Tue, Apr 20, 2010 at 10:18:18PM +1000, Michael Ellerman wrote:
> > On Mon, 2010-04-19 at 23:45 -0700, Christian Kujau wrote:
> > --- a/fs/proc/proc_devtree.c
> > +++ b/fs/proc/proc_devtree.c
> > @@ -175,6 +175,24 @@ retry:
> > return fixed_name;
> > }
> >
> > +static const char *unslash_name(const char *name)
> > +{
> > + char *p, *fixed_name;
> > +
> > + fixed_name = kstrdup(name);
> > + if (!fixed_name) {
> > + printk(KERN_ERR "device-tree: Out of memory trying to unslash "
> > + "name \"%s\"\n", name);
> > + return name;
> > + }
> > +
> > + p = fixed_name;
> > + while ((p = strstr(p, "/")))
> > + *p++ = '_';
>
> This is wasteful. :-)

Whatever, patches welcome :)

> Also, I hope we won't spit message every time allocation fail.

We do. Your system is mostly hosed anyway, but feel free to rate limit
it or something.

The error handling in there is a bit dubious, if the alloc fails we just
return the old name, which we know is bogus. It should probably return
NULL and the calling code can check - same for fixup_name().

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]