From: Heiko Carstens <hca@linux.ibm.com>
To: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/uaccess: introduce bit field for OAC specifier
Date: Fri, 14 Jan 2022 14:58:48 +0100 [thread overview]
Message-ID: <YeGBmPBJ8NMi0Rkp@osiris> (raw)
In-Reply-To: <20220111100003.743116-1-scgl@linux.ibm.com>
On Tue, Jan 11, 2022 at 11:00:03AM +0100, Janis Schoetterl-Glausch wrote:
> From: Nico Boehr <nrb@linux.ibm.com>
>
> Previously, we've used magic values to specify the OAC
> (operand-access control) for mvcos.
>
> Instead we introduce a bit field for it.
>
> When using a bit field, we cannot use an immediate value with K
> constraint anymore, since GCC older than 10 doesn't recognize
> the bit field union as a compile time constant.
> To make things work with older compilers,
> load the OAC value through a register.
>
> Bloat-o-meter reports a slight increase in kernel size with this change:
> Total: Before=15692135, After=15693015, chg +0.01%
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> Co-developed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> ---
> arch/s390/include/asm/uaccess.h | 120 ++++++++++++++++++++------------
> arch/s390/lib/uaccess.c | 24 +++++--
> 2 files changed, 95 insertions(+), 49 deletions(-)
Applied with a couple of indentation + whitespace fixes.
Thanks!
prev parent reply other threads:[~2022-01-14 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 10:00 [PATCH] s390/uaccess: introduce bit field for OAC specifier Janis Schoetterl-Glausch
2022-01-14 13:58 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeGBmPBJ8NMi0Rkp@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=scgl@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox