Re: [PATCH RFT] net: asix: add proper error handling of usb read errors

Oleksij Rempel
2022-02-06T17:54:39Z

Am 06.02.22 um 18:23 schrieb Pavel Skripkin:
> On 1/5/22 16:19, Pavel Skripkin wrote:
>> Syzbot once again hit uninit value in asix driver. The problem still the
>> same -- asix_read_cmd() reads less bytes, than was requested by caller.
>>
>> Since all read requests are performed via asix_read_cmd() let's catch
>> usb related error there and add __must_check notation to be sure all
>> callers actually check return value.
>>
>> So, this patch adds sanity check inside asix_read_cmd(), that simply
>> checks if bytes read are not less, than was requested and adds missing
>> error handling of asix_read_cmd() all across the driver code.
>>
>> Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter")
>> Reported-and-tested-by: syzbot+6ca9f7867b77c2d316ac@syzkaller.appspotmail.com
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>> ---
>
> gentle ping :)

Please resend patch against latest net-next with "net-next" tag instead of "RFT".

--
Regards,
Oleksij