From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] of: base: make small of_parse_phandle() variants static inline
Date: Thu, 20 Jan 2022 11:30:52 -0600 [thread overview]
Message-ID: <YemcTJ640SlBkT0V@robh.at.kernel.org> (raw)
In-Reply-To: <20220118173504.2867523-2-michael@walle.cc>
On Tue, 18 Jan 2022 18:35:02 +0100, Michael Walle wrote:
> Make all the smaller variants of the of_parse_phandle() static inline.
> This also let us remove the empty function stubs if CONFIG_OF is not
> defined.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> changes since v3:
> - rebased due to now signed index parameter
>
> changes since v2:
> - new patch
>
> drivers/of/base.c | 128 ++----------------------------------
> include/linux/of.h | 157 +++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 135 insertions(+), 150 deletions(-)
>
I moved the index < 0 checks into __of_parse_phandle_with_args
and applied, thanks!
next prev parent reply other threads:[~2022-01-20 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 17:35 [PATCH v3 0/3] of: base: of_parse_phandle() cleanup and new variant Michael Walle
2022-01-18 17:35 ` [PATCH v3 1/3] of: base: make small of_parse_phandle() variants static inline Michael Walle
2022-01-20 17:30 ` Rob Herring [this message]
2022-01-18 17:35 ` [PATCH v3 2/3] of: property: define of_property_read_u{8,16,32,64}_array() unconditionally Michael Walle
2022-01-20 17:31 ` Rob Herring
2022-01-18 17:35 ` [PATCH v3 3/3] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-01-24 14:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YemcTJ640SlBkT0V@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).