From: Joerg Roedel <joro@8bytes.org>
To: John Garry <john.garry@huawei.com>
Cc: iommu@lists.linux-foundation.org, Joerg Roedel <jroedel@suse.de>,
linux-kernel@vger.kernel.org,
Maxim Levitsky <mlevitsk@redhat.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable()
Date: Fri, 4 Feb 2022 12:34:38 +0100 [thread overview]
Message-ID: <Yf0PTlYNn/fmIUZU@8bytes.org> (raw)
In-Reply-To: <48a674ae-f5cd-fc06-4505-6d863e6dad69@huawei.com>
On Mon, Jan 31, 2022 at 05:06:03PM +0000, John Garry wrote:
> > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> > index dc338acf3338..d2e09d53851f 100644
> > --- a/drivers/iommu/amd/init.c
> > +++ b/drivers/iommu/amd/init.c
> > @@ -834,6 +834,7 @@ static int iommu_ga_log_enable(struct amd_iommu *iommu)
> > status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
> > if (status & (MMIO_STATUS_GALOG_RUN_MASK))
> > break;
> > + udelay(1);
>
> Maybe readl_relaxed_poll_timeout_atomic() could be used instead
I sent another version of this patch which uses
readl_poll_timeout_atomic(), but it didn't fix the issue. I take this
approach for now and leave using the helper as a future improvement.
Thanks,
Joerg
next prev parent reply other threads:[~2022-02-04 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:17 [PATCH] iommu/amd: Fix loop timeout issue in iommu_ga_log_enable() Joerg Roedel
2022-01-31 17:06 ` John Garry
2022-02-04 11:34 ` Joerg Roedel [this message]
2022-02-01 7:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf0PTlYNn/fmIUZU@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox