* [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
@ 2021-12-31 8:04 Miaoqian Lin
2022-01-13 11:16 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: Miaoqian Lin @ 2021-12-31 8:04 UTC (permalink / raw)
Cc: linmq006, Thomas Zimmermann, Daniel Vetter, Borislav Petkov,
Javier Martinez Canillas, Greg Kroah-Hartman, linux-kernel
Add the missing platform_device_put() before return from
sysfb_create_simplefb() in the error handling case.
Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/firmware/sysfb_simplefb.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
index b86761904949..303a491e520d 100644
--- a/drivers/firmware/sysfb_simplefb.c
+++ b/drivers/firmware/sysfb_simplefb.c
@@ -113,12 +113,16 @@ __init int sysfb_create_simplefb(const struct screen_info *si,
sysfb_apply_efi_quirks(pd);
ret = platform_device_add_resources(pd, &res, 1);
- if (ret)
+ if (ret) {
+ platform_device_put(pd);
return ret;
+ }
ret = platform_device_add_data(pd, mode, sizeof(*mode));
- if (ret)
+ if (ret) {
+ platform_device_put(pd);
return ret;
+ }
return platform_device_add(pd);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
2021-12-31 8:04 [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb Miaoqian Lin
@ 2022-01-13 11:16 ` Javier Martinez Canillas
2022-01-16 12:16 ` [PATCH v2] " Miaoqian Lin
0 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2022-01-13 11:16 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Thomas Zimmermann, Daniel Vetter, Borislav Petkov,
Greg Kroah-Hartman, linux-kernel
Hello Miaoqian,
On 12/31/21 09:04, Miaoqian Lin wrote:
> Add the missing platform_device_put() before return from
> sysfb_create_simplefb() in the error handling case.
>
> Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Thanks for the patch.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
> index b86761904949..303a491e520d 100644
> --- a/drivers/firmware/sysfb_simplefb.c
> +++ b/drivers/firmware/sysfb_simplefb.c
> @@ -113,12 +113,16 @@ __init int sysfb_create_simplefb(const struct screen_info *si,
> sysfb_apply_efi_quirks(pd);
>
> ret = platform_device_add_resources(pd, &res, 1);
> - if (ret)
> + if (ret) {
> + platform_device_put(pd);
> return ret;
> + }
>
> ret = platform_device_add_data(pd, mode, sizeof(*mode));
> - if (ret)
> + if (ret) {
> + platform_device_put(pd);
> return ret;
> + }
>
To avoid duplicating the error code logic twice, you could also do:
if (ret)
goto pdev_put;
> return platform_device_add(pd);
and then after this return statement:
pdev_put:
platform_device_put(pd);
return ret;
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
2022-01-13 11:16 ` Javier Martinez Canillas
@ 2022-01-16 12:16 ` Miaoqian Lin
2022-01-16 17:31 ` Javier Martinez Canillas
0 siblings, 1 reply; 5+ messages in thread
From: Miaoqian Lin @ 2022-01-16 12:16 UTC (permalink / raw)
To: javierm; +Cc: bp, daniel.vetter, gregkh, linmq006, linux-kernel, tzimmermann
Add the missing platform_device_put() before return from
sysfb_create_simplefb() in the error handling case.
Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
Changes in v2:
- Use goto label to avoid duplicating the error code logic.
---
drivers/firmware/sysfb_simplefb.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
index b86761904949..46d776c29174 100644
--- a/drivers/firmware/sysfb_simplefb.c
+++ b/drivers/firmware/sysfb_simplefb.c
@@ -114,11 +114,15 @@ __init int sysfb_create_simplefb(const struct screen_info *si,
ret = platform_device_add_resources(pd, &res, 1);
if (ret)
- return ret;
+ goto pdev_put;
ret = platform_device_add_data(pd, mode, sizeof(*mode));
if (ret)
- return ret;
+ goto pdev_put;
return platform_device_add(pd);
+
+pdev_put:
+ platform_device_put(pd);
+ return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
2022-01-16 12:16 ` [PATCH v2] " Miaoqian Lin
@ 2022-01-16 17:31 ` Javier Martinez Canillas
2022-02-04 15:41 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Javier Martinez Canillas @ 2022-01-16 17:31 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: bp, daniel.vetter, gregkh, linux-kernel, tzimmermann
On 1/16/22 13:16, Miaoqian Lin wrote:
> Add the missing platform_device_put() before return from
> sysfb_create_simplefb() in the error handling case.
>
> Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> Changes in v2:
> - Use goto label to avoid duplicating the error code logic.
> ---
> drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
2022-01-16 17:31 ` Javier Martinez Canillas
@ 2022-02-04 15:41 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2022-02-04 15:41 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Miaoqian Lin, bp, daniel.vetter, linux-kernel, tzimmermann
On Sun, Jan 16, 2022 at 06:31:09PM +0100, Javier Martinez Canillas wrote:
> On 1/16/22 13:16, Miaoqian Lin wrote:
> > Add the missing platform_device_put() before return from
> > sysfb_create_simplefb() in the error handling case.
> >
> > Fixes: 8633ef8 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > ---
> > Changes in v2:
> > - Use goto label to avoid duplicating the error code logic.
> > ---
> > drivers/firmware/sysfb_simplefb.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-04 15:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-31 8:04 [PATCH] drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb Miaoqian Lin
2022-01-13 11:16 ` Javier Martinez Canillas
2022-01-16 12:16 ` [PATCH v2] " Miaoqian Lin
2022-01-16 17:31 ` Javier Martinez Canillas
2022-02-04 15:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox