From: Rob Herring <robh@kernel.org>
To: Rajeev Nandan <quic_rajeevny@quicinc.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sean@poorly.run, daniel@ffwll.ch,
quic_abhinavk@quicinc.com, quic_kalyant@quicinc.com,
quic_mkrishn@quicinc.com, linux-arm-msm@vger.kernel.org,
airlied@linux.ie, jonathan@marek.ca, dmitry.baryshkov@linaro.org,
swboyd@chromium.org, freedreno@lists.freedesktop.org,
robh+dt@kernel.org, robdclark@gmail.com
Subject: Re: [v5 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties
Date: Fri, 4 Feb 2022 16:37:16 -0600 [thread overview]
Message-ID: <Yf2qnHguXCyWLj4f@robh.at.kernel.org> (raw)
In-Reply-To: <1643573719-32095-2-git-send-email-quic_rajeevny@quicinc.com>
On Mon, 31 Jan 2022 01:45:17 +0530, Rajeev Nandan wrote:
> In most cases, the default values of DSI PHY tuning registers should be
> sufficient as they are fully optimized. However, in some cases where
> extreme board parasitics cause the eye shape to degrade, the override
> bits can be used to improve the signal quality.
>
> The general guidelines for DSI PHY tuning include:
> - High and moderate data rates may benefit from the drive strength and
> drive level tuning.
> - Drive strength tuning will affect the output impedance and may be used
> for matching optimization.
> - Drive level tuning will affect the output levels without affecting the
> impedance.
>
> The clock and data lanes have a calibration circuitry feature. The drive
> strength tuning can be done by adjusting rescode offset for hstop/hsbot,
> and the drive level tuning can be done by adjusting the LDO output level
> for the HSTX drive.
>
> Signed-off-by: Rajeev Nandan <quic_rajeevny@quicinc.com>
> ---
>
> Changes in v2:
> - More details in the commit text (Stephen Boyd)
> - Use human understandable values (Stephen Boyd, Dmitry Baryshkov)
> - Do not take values that are going to be unused (Dmitry Baryshkov)
>
> Changes in v3:
> - Use "qcom," prefix (Dmitry Baryshkov)
> - Remove encoding from phy-drive-ldo-level (Dmitry Baryshkov)
> - Use negative values instead of two's complement (Dmitry, Rob Herring)
>
> Changes in v4:
> - Fix dt_binding_check error (Rob Herring's bot)
>
> Changes in v5:
> - None
>
> .../bindings/display/msm/dsi-phy-10nm.yaml | 36 ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-02-04 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 20:15 [v5 0/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support Rajeev Nandan
2022-01-30 20:15 ` [v5 1/3] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties Rajeev Nandan
2022-02-04 22:37 ` Rob Herring [this message]
2022-01-30 20:15 ` [v5 2/3] drm/msm/dsi: Add dsi phy tuning configuration support Rajeev Nandan
2022-01-30 20:15 ` [v5 3/3] drm/msm/dsi: Add 10nm " Rajeev Nandan
2022-01-31 17:08 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf2qnHguXCyWLj4f@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox