From: Andrew Lunn <andrew@lunn.ch>
To: Raag Jadav <raagjadav@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steen Hegelund <steen.hegelund@microchip.com>,
Bjarni Jonasson <bjarni.jonasson@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: mscc: enable MAC SerDes autonegotiation
Date: Sat, 5 Feb 2022 15:57:49 +0100 [thread overview]
Message-ID: <Yf6QbbqaxZhZPUdC@lunn.ch> (raw)
In-Reply-To: <1644043492-31307-1-git-send-email-raagjadav@gmail.com>
On Sat, Feb 05, 2022 at 12:14:52PM +0530, Raag Jadav wrote:
> Enable MAC SerDes autonegotiation to distinguish between
> 1000BASE-X, SGMII and QSGMII MAC.
How does autoneg help you here? It just tells you about duplex, pause
etc. It does not indicate 1000BaseX, SGMII etc. The PHY should be
using whatever mode it was passed in phydev->interface, which the MAC
sets when it calls the connection function. If the PHY dynamically
changes its host side mode as a result of what that line side is
doing, it should also change phydev->interface. However, as far as i
can see, the mscc does not do this.
So i don't understand this commit message.
Andrew
next prev parent reply other threads:[~2022-02-05 14:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 6:44 [PATCH] net: phy: mscc: enable MAC SerDes autonegotiation Raag Jadav
2022-02-05 14:57 ` Andrew Lunn [this message]
2022-02-06 17:12 ` Raag Jadav
2022-02-06 17:18 ` Russell King (Oracle)
2022-02-06 18:01 ` Andrew Lunn
2022-02-07 17:49 ` Raag Jadav
2022-02-08 2:09 ` Andrew Lunn
2022-02-08 15:57 ` Raag Jadav
2022-02-08 16:01 ` Russell King (Oracle)
2022-02-08 19:12 ` Andrew Lunn
2022-02-10 16:48 ` Raag Jadav
2022-02-08 9:45 ` Russell King (Oracle)
2022-02-08 15:53 ` Raag Jadav
2022-02-24 10:41 ` Siddharth Narayan Vadapalli
2022-02-24 10:48 ` Russell King (Oracle)
2022-02-26 7:23 ` Raag Jadav
2022-02-26 16:31 ` Russell King (Oracle)
2022-03-27 8:32 ` Raag Jadav
2022-03-24 10:06 ` Siddharth Vadapalli
2022-03-27 8:30 ` Raag Jadav
2022-03-28 8:13 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf6QbbqaxZhZPUdC@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=raagjadav@gmail.com \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox