From: Andrew Lunn <andrew@lunn.ch>
To: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Ron Madrid <ron_madrid@sbcglobal.net>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
stable@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: marvell: Fix MDI-x polarity setting in 88e1118-compatible PHYs
Date: Sat, 5 Feb 2022 23:02:07 +0100 [thread overview]
Message-ID: <Yf7z33SdwW9dwTdD@lunn.ch> (raw)
In-Reply-To: <20220205214951.60371-1-Pavel.Parkhomenko@baikalelectronics.ru>
On Sun, Feb 06, 2022 at 12:49:51AM +0300, Pavel Parkhomenko wrote:
> When setting up autonegotiation for 88E1118R and compatible PHYs,
> a software reset of PHY is issued before setting up polarity.
> This is incorrect as changes of MDI Crossover Mode bits are
> disruptive to the normal operation and must be followed by a
> software reset to take effect. Let's patch m88e1118_config_aneg()
> to fix the issue mentioned before by invoking software reset
> of the PHY just after setting up MDI-x polarity.
>
> Fixes: 605f196efbf8 ("phy: Add support for Marvell 88E1118 PHY")
> Signed-off-by: Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Cc: stable@vger.kernel.org
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-02-05 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 21:49 [PATCH net] net: phy: marvell: Fix MDI-x polarity setting in 88e1118-compatible PHYs Pavel Parkhomenko
2022-02-05 22:02 ` Andrew Lunn [this message]
2022-02-06 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf7z33SdwW9dwTdD@lunn.ch \
--to=andrew@lunn.ch \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=davem@davemloft.net \
--cc=fancer.lancer@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ron_madrid@sbcglobal.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox