From: Tzung-Bi Shih <tzungbi@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, Alyssa Ross <hi@alyssa.is>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Check for EC device
Date: Wed, 26 Jan 2022 11:46:38 +0800 [thread overview]
Message-ID: <YfDEHoYkLc6zjSxj@google.com> (raw)
In-Reply-To: <20220126012203.2979709-1-pmalani@chromium.org>
On Wed, Jan 26, 2022 at 01:22:03AM +0000, Prashant Malani wrote:
> Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
> Reported-by: Alyssa Ross <hi@alyssa.is>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
With a minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> @@ -1076,6 +1076,12 @@ static int cros_typec_probe(struct platform_device *pdev)
>
> typec->dev = dev;
> typec->ec = dev_get_drvdata(pdev->dev.parent);
> +
I would prefer to remove the blank line to make it look like an integrated block.
> + if (!typec->ec) {
> + dev_err(dev, "couldn't find parent EC device\n");
> + return -ENODEV;
> + }
> +
next prev parent reply other threads:[~2022-01-26 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 1:22 [PATCH] platform/chrome: cros_ec_typec: Check for EC device Prashant Malani
2022-01-26 3:46 ` Tzung-Bi Shih [this message]
2022-01-26 4:05 ` Prashant Malani
2022-01-26 15:33 ` Guenter Roeck
2022-01-26 18:56 ` Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfDEHoYkLc6zjSxj@google.com \
--to=tzungbi@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hi@alyssa.is \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox