Re: [PATCH 13/15] arm64: dts: qcom: Add MSM8953+PM8953 device tree

Luca Weiss
2022-02-13T20:25:32Z

Hi Bjorn,

On Montag, 31. Jänner 2022 23:39:06 CET Bjorn Andersson wrote:
> On Wed 12 Jan 13:41 CST 2022, Luca Weiss wrote:
> > From: Vladimir Lypak <vladimir.lypak@gmail.com>
> >
> > The combination MSM8953 + PM8953 is commonly used, so add a
> > device tree where common power supplies etc. can be configured.
> >
> > Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> I would prefer if we stick with the current scheme and just push this
> into the device dts (or possibly some vendor-common dtsi if that's
> applicable).
>
> Simply just to follow what we do on other platforms.

Sure, will do in v2.

>
>
> PS. I see some patches has been applied, but as you resubmit this
> series please split it per maintainer to make it obvious to each
> maintainer that they should pick their part(s).

What do you mean by this? Send one series per maintainer? Or something else?

Currently when making the patches I don't really "care" about who maintains
what, my git send-email setup picks the relevant people for CC.

Sometimes there's also multiple maintainers/trees listed for one file, not sure
what to do there...

Regards
Luca

>
> Thanks,
> Bjorn
>
> > ---
> >
> > arch/arm64/boot/dts/qcom/msm8953-pm8953.dtsi | 50 ++++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/msm8953-pm8953.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8953-pm8953.dtsi
> > b/arch/arm64/boot/dts/qcom/msm8953-pm8953.dtsi new file mode 100644
> > index 000000000000..b5f20fc9488e
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/msm8953-pm8953.dtsi
> > @@ -0,0 +1,50 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/* Copyright (c) 2022, The Linux Foundation. All rights reserved. */
> > +
> > +#include "msm8953.dtsi"
> > +#include "pm8953.dtsi"
> > +
> > +&hsusb_phy {
> > + vdd-supply = <&pm8953_l3>;
> > + vdda-pll-supply = <&pm8953_l7>;
> > + vdda-phy-dpdm-supply = <&pm8953_l13>;
> > +};
> > +
> > +&sdhc_1 {
> > + vmmc-supply = <&pm8953_l8>;
> > + vqmmc-supply = <&pm8953_l5>;
> > +};
> > +
> > +&sdhc_2 {
> > + vmmc-supply = <&pm8953_l11>;
> > + vqmmc-supply = <&pm8953_l12>;
> > +};
> > +
> > +&rpm_requests {
> > + smd_rpm_regulators: pm8953-regulators {
> > + compatible = "qcom,rpm-pm8953-regulators";
> > +
> > + pm8953_s1: s1 {};
> > + pm8953_s3: s3 {};
> > + pm8953_s4: s4 {};
> > +
> > + pm8953_l1: l1 {};
> > + pm8953_l2: l2 {};
> > + pm8953_l3: l3 {};
> > + pm8953_l5: l5 {};
> > + pm8953_l6: l6 {};
> > + pm8953_l7: l7 {};
> > + pm8953_l8: l8 {};
> > + pm8953_l9: l9 {};
> > + pm8953_l10: l10 {};
> > + pm8953_l11: l11 {};
> > + pm8953_l12: l12 {};
> > + pm8953_l13: l13 {};
> > + pm8953_l15: l15 {};
> > + pm8953_l16: l16 {};
> > + pm8953_l17: l17 {};
> > + pm8953_l19: l19 {};
> > + pm8953_l22: l22 {};
> > + pm8953_l23: l23 {};
> > + };
> > +};