From: Christoph Hellwig <hch@infradead.org>
To: Yang Shi <shy828301@gmail.com>
Cc: axboe@kernel.dk, hch@infradead.org, rostedt@goodmis.org,
xiyou.wangcong@gmail.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v5 PATCH] block: introduce block_rq_error tracepoint
Date: Thu, 27 Jan 2022 01:53:54 -0800 [thread overview]
Message-ID: <YfJrsid0OJQykXYz@infradead.org> (raw)
In-Reply-To: <20220126185153.417948-1-shy828301@gmail.com>
On Wed, Jan 26, 2022 at 10:51:53AM -0800, Yang Shi wrote:
> + __entry->dev = rq->q->disk ? disk_devt(rq->q->disk) : 0;
> + __assign_str(name, rq->q->disk ? rq->q->disk->disk_name : "?");
None f the other tracepoints has the disk name, why does this one need
it? And if you add it please avoid the overly long line.
> + __entry->sector = blk_rq_pos(rq);
> + __entry->nr_sector = nr_bytes >> 9;
> + __entry->error = blk_status_to_errno(error);
This still converts the block status to an errno.
next prev parent reply other threads:[~2022-01-27 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:51 [v5 PATCH] block: introduce block_rq_error tracepoint Yang Shi
2022-01-27 8:02 ` Chaitanya Kulkarni
2022-01-27 9:52 ` hch
2022-01-27 18:18 ` Yang Shi
2022-01-27 9:53 ` Christoph Hellwig [this message]
2022-01-27 18:18 ` Yang Shi
2022-02-02 17:47 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfJrsid0OJQykXYz@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shy828301@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox