From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101C7C4332F for ; Fri, 28 Jan 2022 13:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348754AbiA1Ndh (ORCPT ); Fri, 28 Jan 2022 08:33:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241847AbiA1Ndd (ORCPT ); Fri, 28 Jan 2022 08:33:33 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 655BAC061714 for ; Fri, 28 Jan 2022 05:33:33 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id j5-20020a05600c1c0500b0034d2e956aadso4052313wms.4 for ; Fri, 28 Jan 2022 05:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Q2chQh3ZSa0GKVYP8Nl+va6NIlD47CmgDYXabLwHRf4=; b=upODrhy8ePG/VCMU4473jl1Sdijg6hUhxr2gg/04BSQGSi1Qa36DGGHRWQm/PYeC3a xKCFMY5GdD+AUzImrO1FpzZ7DgmEubzJtwMf1rSW06qAJrdS+CfSjeJIz3tB2L9itL8M t84u1FIYoXG0mD21ipbLcE+j4NID4fmQxKVZlhoGh37rN587sXiqhykJT5a+EgV7/GiA 3VFN1s9BIqkim3VGde1zMAQopJ1x3hyI4ndYc47DotTKayozQRgTxaHkpn0ATCEzEHJg Ew9vcGHePF8au1q/nBENQHcaESsI9ao/39z9BxYAs9/g64SrtkBij+Q1+qiJqJwuD8Xa Ur8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Q2chQh3ZSa0GKVYP8Nl+va6NIlD47CmgDYXabLwHRf4=; b=7uRDV5/6lwl/zkCidT+/g0z47PB4/rjbv7/B4XbmhGST5P33dw58WiaWOH69Sir7eA PnHAKy+SUXJXfHTvfN9fUnrNrsukKMEbHCPQKe7NHOpHBO1lIvfqkz6oNWCJIwbyD33y oLXX/uwR/yVlv1u9GRbR/BGpYQgZdMo/ZJN9vOE9dkx8FOwAP8yRwQJfKPdgCS5e8vjS QcTTauAWw6yGBA+RZ+eTYentJtJ5hMM65VRkWgV7VTBPIt39IeOtDh6SrBwZyOKxUVKy XA8xuLG+BIQfY1VqUJkdwOapd/LMNeyLmzKibdeBLQJa8Fr4M1AmmJxHaq7E5wBzDqsR 25Qg== X-Gm-Message-State: AOAM532kZO/dshd9EHeFArupejiBtLZAWJN1DWfL+svTIInc8DK9LdjQ yvvZSduhTFk3+RSna8dkFRIFNQ== X-Google-Smtp-Source: ABdhPJzn0kNxpSEYDJe2S2sKSIy8rks03D7V2gQmW0Kx2m1LfEjk74vmNIHJ7QMjgSY95nCyamOiWQ== X-Received: by 2002:a05:600c:1ca0:: with SMTP id k32mr5942424wms.62.1643376811978; Fri, 28 Jan 2022 05:33:31 -0800 (PST) Received: from google.com (cpc106310-bagu17-2-0-cust853.1-3.cable.virginm.net. [86.15.223.86]) by smtp.gmail.com with ESMTPSA id y6sm1876155wma.48.2022.01.28.05.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 05:33:31 -0800 (PST) Date: Fri, 28 Jan 2022 13:33:29 +0000 From: Lee Jones To: Sergei Shtylyov Cc: Sebastian Andrzej Siewior , greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Alex Elder , Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , Jakub Kicinski , Johan Hovold , Rui Miguel Silva , Thomas Gleixner , UNGLinuxDriver@microchip.com, Wolfram Sang , Woojung Huh Subject: Re: [PATCH 4/7] mfd: hi6421-spmi-pmic: Use generic_handle_irq_safe(). Message-ID: References: <20220127113303.3012207-1-bigeasy@linutronix.de> <20220127113303.3012207-5-bigeasy@linutronix.de> <44b42c37-67a4-1d20-e2ff-563d4f9bfae2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <44b42c37-67a4-1d20-e2ff-563d4f9bfae2@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jan 2022, Sergei Shtylyov wrote: > On 1/27/22 2:33 PM, Sebastian Andrzej Siewior wrote: > > > generic_handle_irq() is invoked from a regular interrupt service > > routing. This handler will become a forced-threaded handler on > > s/routing/routine/? > > > PREEMPT_RT and will be invoked with enabled interrupts. The > > generic_handle_irq() must be invoked with disabled interrupts in order > > to avoid deadlocks. > > > > Instead of manually disabling interrupts before invoking use > > generic_handle_irq() which can be invoked with enabled and disabled > > interrupts. > > > > Signed-off-by: Sebastian Andrzej Siewior > [...] > > MBR, Sergey What does that mean? -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog