From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 0/3] Handle chroot tasks properly (v1)
Date: Tue, 1 Feb 2022 21:11:56 -0300 [thread overview]
Message-ID: <YfnMTIsKMLAnbF8P@kernel.org> (raw)
In-Reply-To: <CAM9d7ciUqaZ02AV4xiknhyAKx0U-4GYKNGJWCa0P=5_CdpxoLg@mail.gmail.com>
Em Tue, Feb 01, 2022 at 12:01:49PM -0800, Namhyung Kim escreveu:
> On Mon, Jan 31, 2022 at 5:16 PM Andi Kleen <ak@linux.intel.com> wrote:
> > On 1/28/2022 12:39 PM, Namhyung Kim wrote:
> > > I found that perf tools don't work well with tasks in a chroot. The
> > > filenames in MMAP record are from the root directory of the task so
> > > it's different than what it sees from outside.
> > While that's a real problem, and for chroot it can be fixed, it's much
> > more complicated for the more complex container namespace case with
> > custom mounts, including loop back, etc.
> Probably. Note that perf tool can handle namespaces (to some extent)
> but missed chroot support. I have a bug report because of this issue.
> Let's fix the simple case first.
> > It seems it really need some kind of agent to handle all cases. For
> > example the agent could understand container metadata formats and then
> > do the right thing.
>
> Sounds like a good idea for a long term solution.
I think build ids are the way to go and would be really happy to have
arguments against it to be properly spelled out so we can harvest
documentation.
Its really difficult to associate a mmap to a backing storage, its race
prone, so having something that uniquely identifies the contents at the
time of mmap placement hugely desirable.
We seem to have that in most cases, and there is discussion about what
to do to the cases where parsing the ELF headers when that area is not
in memory, so there is hope that the buildid for an exec VMA will be
always available.
- Arnaldo
prev parent reply other threads:[~2022-02-02 0:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 20:39 [PATCH 0/3] Handle chroot tasks properly (v1) Namhyung Kim
2022-01-28 20:39 ` [PATCH 1/3] perf tools: Try chroot'ed filename when opening dso/symbol Namhyung Kim
2022-01-28 20:39 ` [PATCH 2/3] perf inject: Try chroot directory when reading build-id Namhyung Kim
2022-01-28 20:39 ` [PATCH 3/3] perf annotate: Try chroot filename for objdump Namhyung Kim
2022-01-31 19:23 ` Jiri Olsa
2022-02-01 19:54 ` Namhyung Kim
2022-02-02 0:06 ` Arnaldo Carvalho de Melo
2022-02-01 1:16 ` [PATCH 0/3] Handle chroot tasks properly (v1) Andi Kleen
2022-02-01 20:01 ` Namhyung Kim
2022-02-02 0:11 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfnMTIsKMLAnbF8P@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox