From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D183C433FE for ; Wed, 2 Feb 2022 22:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347950AbiBBWwB (ORCPT ); Wed, 2 Feb 2022 17:52:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237605AbiBBWv7 (ORCPT ); Wed, 2 Feb 2022 17:51:59 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA266C06173B for ; Wed, 2 Feb 2022 14:51:58 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id e16so725308pgn.4 for ; Wed, 02 Feb 2022 14:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lPEgbuxslnTLTy0cKW6Sngl50vamSxtuVPfB7iySKa8=; b=dTX3bLDcEE54y6c/+Kkj6MTxo87Yu+ZsaHiJo7j2dp5a0WukhoMaez16sY2J9ItoI2 8sZRPFs7ZP+OtpiyrsdMbRVYmv/Mcf9lFF0yM7CBdQUQuNgGYJmXtyiBxGJi6CPmYj5u yBanI0mVHsA1zAux5JwbqCUhZ3uctbdbQOTnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lPEgbuxslnTLTy0cKW6Sngl50vamSxtuVPfB7iySKa8=; b=dNGs9WSe2Z1AAP45x8oauj1/YjdXeXzJfEcmR36ckxMQMeoEC86PN7mjeWwu7yttBD OZc7GE3Q4/fzKCCvVmuEEGI3bRDyXNpo3hGUQBxmQ5gUsO33Pqxd0GPo3ITZ/p8abKgS sKrP73Sd3K1NylkXFD8hYSTsKgqijT94rMIenxhSEBoATZFDaa/anh6jMGW0sSGjA/SX leFiPDO4X2STNJlC5cshiWybTyWVI0nnkoV154x46zp2GEv/zFw/+QtkOLJcWyjM6neZ Dw0JFOSZCKczSHXjePUzTzkoCmNQVVeFkgp3nJXXMBmvq2S9r/WqukMYp4EeBK/L2I7t kjVA== X-Gm-Message-State: AOAM530cazEPeDq33kgQDKGt5PMj83yPOYP5bv3BiAlH6k6bowTwG5t3 BIzKYGGyqefUC1SaYcZYmKnAFg== X-Google-Smtp-Source: ABdhPJxejDh6p3N4BhaMrEV1Rd6fCUIEukCr6nZ/aaOTaDYGJBLHkze6Ky6n9rUQeMOBu97PiDSTzA== X-Received: by 2002:a63:285:: with SMTP id 127mr25890891pgc.67.1643842318226; Wed, 02 Feb 2022 14:51:58 -0800 (PST) Received: from localhost ([2620:15c:202:201:c0cb:3065:aa0:d6c9]) by smtp.gmail.com with UTF8SMTPSA id l14sm38679188pgn.50.2022.02.02.14.51.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 14:51:57 -0800 (PST) Date: Wed, 2 Feb 2022 14:51:56 -0800 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , pmaliset@codeaurora.org, quic_rjendra@quicinc.com, Shaik Sajida Bhanu , kgodara@codeaurora.org, konrad.dybcio@somainline.org, Sankeerth Billakanti , sibis@codeaurora.org, swboyd@chromium.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/14] arm64: dts: qcom: sc7280: Add edp_out port and HPD lines Message-ID: References: <20220202212348.1391534-1-dianders@chromium.org> <20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220202132301.v3.7.Ic84bb69c45be2fccf50e3bd17b845fe20eec624c@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 02, 2022 at 01:23:41PM -0800, Douglas Anderson wrote: > Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't > need to do this in the board files. > > Like dp_hot_plug_det, we should define edp_hot_plug_det in > sc7280.dtsi. > > We should set the default pinctrl for edp_hot_plug_det in > sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is > reasonable that in some boards the dedicated DP Hot Plug Detect will > not be hooked up in favor of Type C mechanisms. This is unlike eDP > where the Hot Plug Detect line (which functions as "panel ready" in > eDP) is highly likely to be used by boards. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke