From: Andrew Lunn <andrew@lunn.ch>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Martin Schiller <ms@dev.tdt.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
martin.blumenstingl@googlemail.com,
Florian Fainelli <f.fainelli@gmail.com>,
hkallweit1@gmail.com,
Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
kuba@kernel.org, netdev <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3] net: phy: intel-xway: enable integrated led functions
Date: Thu, 3 Feb 2022 02:01:31 +0100 [thread overview]
Message-ID: <YfspazpWoKuHEwPU@lunn.ch> (raw)
In-Reply-To: <CAJ+vNU1=4sDmGXEzPwp0SCq4_p0J-odw-GLM=Qyi7zQnVHwQRA@mail.gmail.com>
> As a person responsible for boot firmware through kernel for a set of
> boards I continue to do the following to keep Linux from mucking with
> various PHY configurations:
> - remove PHY reset pins from Linux DT's to keep Linux from hard resetting PHY's
> - disabling PHY drivers
>
> What are your thoughts about this?
Hi Tim
I don't like the idea that the bootloader is controlling the hardware,
not linux.
There are well defined ways for telling Linux how RGMII delays should
be set, and most PHY drivers do this. Any which don't should be
extended to actually set the delay as configured.
LEDs are trickier. There is a slow on going effort to allow PHY LEDs
to be configured as standard Linux LEDs. That should result in a DT
binding which can be used to configure LEDs from DT.
You probably are going to have more and more issues if you think the
bootloader is controlling the hardware, so you really should stop
trying to do that.
Andrew
next prev parent reply other threads:[~2022-02-03 1:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 5:50 [PATCH net v3] net: phy: intel-xway: enable integrated led functions Martin Schiller
2021-04-21 18:10 ` patchwork-bot+netdevbpf
2021-04-21 21:25 ` Martin Blumenstingl
2022-02-01 20:54 ` Tim Harvey
2022-02-03 1:01 ` Andrew Lunn [this message]
2022-02-03 3:12 ` Florian Fainelli
2022-02-03 16:02 ` Tim Harvey
2022-02-04 17:06 ` Florian Fainelli
2022-02-03 15:57 ` Tim Harvey
2022-02-03 16:37 ` Andrew Lunn
2022-02-03 17:52 ` Tim Harvey
2022-02-04 0:04 ` Andrew Lunn
2022-02-04 22:35 ` Tim Harvey
2022-02-04 22:54 ` Andrew Lunn
2022-02-09 16:31 ` Tim Harvey
2022-02-10 0:04 ` Andrew Lunn
2022-02-10 15:52 ` Tim Harvey
2022-02-11 19:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfspazpWoKuHEwPU@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox