From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98526C433F5 for ; Thu, 3 Feb 2022 06:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347356AbiBCGxW (ORCPT ); Thu, 3 Feb 2022 01:53:22 -0500 Received: from muru.com ([72.249.23.125]:45688 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244639AbiBCGxS (ORCPT ); Thu, 3 Feb 2022 01:53:18 -0500 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E02E480EE; Thu, 3 Feb 2022 06:53:02 +0000 (UTC) Date: Thu, 3 Feb 2022 08:53:15 +0200 From: Tony Lindgren To: Drew Fustini Cc: Daniel Lezcano , Keerthy , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tero Kristo , khilman@baylibre.com, s-anna@ti.com Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix Message-ID: References: <20220202212554.1316032-1-dfustini@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220202212554.1316032-1-dfustini@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Drew Fustini [220202 23:26]: > I modified the errata fix to use timer 15 and 16 instead which resolves > the timer conflict. Makes sens to me, just one nit below. > Note: I am keeping the device tree and driver change together in one > patch as that is how the original errata fix commit was structured. Yes.. The old dtb handling for the timer driver causes this dependency unfortunately. > --- a/drivers/clocksource/timer-ti-dm-systimer.c > +++ b/drivers/clocksource/timer-ti-dm-systimer.c > @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa) > return 0; > } > > - if (pa == 0x48034000) /* dra7 dmtimer3 */ > + if (pa == 0x4882C000) /* dra7 dmtimer15 */ > return dmtimer_percpu_timer_init(np, 0); > - else if (pa == 0x48036000) /* dra7 dmtimer4 */ > + else if (pa == 0x4882E000) /* dra7 dmtimer16 */ > return dmtimer_percpu_timer_init(np, 1); > > return 0; Linux use lower case hex number typically :) With that, please feel free to add: Reviewed-by: Tony Lindgren