Re: [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers

Greg KH
2022-01-27T10:59:16Z

On Thu, Jan 27, 2022 at 11:49:03AM +0100, Oleksij Rempel wrote:
> Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> import all currently supported USB IDs form drivers/net/usb/smsc95xx.c

That is a loosing game to play. There is a reason that kernel drivers
only require a device id in 1 place, instead of multiple places like
other operating systems. Please do not go back and make the same
mistakes others have.

Not to mention that I think overall this is a bad idea anyway. USB
devices are self-describing, don't add them to DT.

thanks,

greg k-h