Re: [PATCH v9 37/43] x86/sev: Add SEV-SNP feature detection/setup

Borislav Petkov
2022-02-06T19:38:39Z

On Fri, Jan 28, 2022 at 11:17:58AM -0600, Brijesh Singh wrote:
> +static __init struct cc_blob_sev_info *snp_find_cc_blob(struct boot_params *bp)
> +{
> + struct cc_blob_sev_info *cc_info;
> +
> + /* Boot kernel would have passed the CC blob via boot_params. */
> + if (bp->cc_blob_address) {
> + cc_info = (struct cc_blob_sev_info *)(unsigned long)bp->cc_blob_address;
> + goto found_cc_info;
> + }

What is the difference here, why aren't you looking for the blob in an
EFI table?

Even if you're booted directly by firmware, there should still be EFI
there or?

And if so, then I think you should share some of the code through
sev-shared.c so that there's not so much duplication...

--
Regards/Gruss,
Boris.