From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Petr Mladek" <pmladek@suse.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Xiaoming Ni" <nixiaoming@huawei.com>,
linux-kernel@vger.kernel.org, "kernel test robot" <lkp@intel.com>,
"Mickaël Salaün" <mic@linux.microsoft.com>
Subject: Re: [PATCH v1] printk: Fix incorrect __user type in proc_dointvec_minmax_sysadmin()
Date: Fri, 4 Feb 2022 12:09:55 +0900 [thread overview]
Message-ID: <YfyZAy+ZDZ4SXIFE@google.com> (raw)
In-Reply-To: <20220203145029.272640-1-mic@digikod.net>
On (22/02/03 15:50), Mickaël Salaün wrote:
> The move of proc_dointvec_minmax_sysadmin() from kernel/sysctl.c to
> kernel/printk/sysctl.c introduced an incorrect __user attribute to the
> buffer argument. I spotted this change in [1] as well as the kernel
> test robot. Revert this change to please sparse:
>
> kernel/printk/sysctl.c:20:51: warning: incorrect type in argument 3 (different address spaces)
> kernel/printk/sysctl.c:20:51: expected void *
> kernel/printk/sysctl.c:20:51: got void [noderef] __user *buffer
>
> Fixes: faaa357a55e0 ("printk: move printk sysctl to printk/sysctl.c")
> Link: https://lore.kernel.org/r/20220104155024.48023-2-mic@digikod.net [1]
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: John Ogness <john.ogness@linutronix.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Petr Mladek <pmladek@suse.com>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Xiaoming Ni <nixiaoming@huawei.com>
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> Link: https://lore.kernel.org/r/20220203145029.272640-1-mic@digikod.net
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2022-02-04 3:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 14:50 [PATCH v1] printk: Fix incorrect __user type in proc_dointvec_minmax_sysadmin() Mickaël Salaün
2022-02-04 3:09 ` Sergey Senozhatsky [this message]
2022-02-04 21:51 ` Luis Chamberlain
2022-02-04 21:52 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfyZAy+ZDZ4SXIFE@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=mic@digikod.net \
--cc=mic@linux.microsoft.com \
--cc=nixiaoming@huawei.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox