From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6899CC433FE for ; Wed, 16 Feb 2022 15:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbiBPPpw (ORCPT ); Wed, 16 Feb 2022 10:45:52 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235698AbiBPPpp (ORCPT ); Wed, 16 Feb 2022 10:45:45 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1EC2A5989 for ; Wed, 16 Feb 2022 07:45:32 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B2BF1F37D; Wed, 16 Feb 2022 15:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1645026331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XvA8U4SyXCnsVseKo1yffsTrzZzqNOcqdAeYZByR8+I=; b=2Q53fou1I48/b1Noz3GJHj2JY6/nWjIJJ+yDMxryp4s/5pMmCaulIVGCad2VVPQx0If1LA foqCjjalX8Wp0ydrU0Iwo/4IXdFsACip3D2cCcNyZmm0OqKU8JKNSnFwG5FU3ZtwqqbmEb TCIy3qr/Q5KA3ozi4L7wN0O6px6ky44= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1645026331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XvA8U4SyXCnsVseKo1yffsTrzZzqNOcqdAeYZByR8+I=; b=SAwW6Ub/Lwy40IYtgZGqLS7p8pjgIXHY5OVO945Ls+lkhtVrgLIZRqD6vw6s0fz5m+QyaJ L08F7rfWSp7Bi+DA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EE23C13B15; Wed, 16 Feb 2022 15:45:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qUoSNxocDWJxOgAAMHmgww (envelope-from ); Wed, 16 Feb 2022 15:45:30 +0000 Date: Wed, 16 Feb 2022 16:45:29 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Rafael J. Wysocki" , Greg Kroah-Hartman , Michal Hocko , Rafael Parra Subject: Re: [PATCH v2 2/2] drivers/base/memory: determine and store zone for single-zone memory blocks Message-ID: References: <20220210184359.235565-1-david@redhat.com> <20220210184359.235565-3-david@redhat.com> <9738c049-a6a2-19f7-f9be-e7ae98c2c66b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9738c049-a6a2-19f7-f9be-e7ae98c2c66b@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 02:46:56PM +0100, David Hildenbrand wrote: > And yes, add_memory_block() chould __init, that would also make it > clearer out of which context init_memory_block() is called with > MEM_ONLINE. I can send an addon patch for that! Yeah, I think that would have helped me, and it definitely makes it more clear, so go ahead ;-) -- Oscar Salvador SUSE Labs