From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCDEC433EF for ; Sun, 6 Feb 2022 21:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244514AbiBFVuF (ORCPT ); Sun, 6 Feb 2022 16:50:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241378AbiBFVuC (ORCPT ); Sun, 6 Feb 2022 16:50:02 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CC80C06173B; Sun, 6 Feb 2022 13:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MYhRHqxCkUHKTTrVS6ypQppPy8pN9/E8VMnKemjP0yE=; b=PCQuNQJZFJc/hohvYN3oMbB7c4 Bd7Q7Zp+Lu+UTf0+6YAgQ+afo6/qgHLrVKNgI//8DbWLYldG4CBLlyjr8Btr+ab22cPjiwFuzjazH GazIGv4hzFjSjHU2QjnIcO7L8zcxjAplIirtEifXxOv70IgJrqSyY7PDQ8xITLEeE9PEXpXpqMlEl NRGbhTNrZu6evhmOoR1CNy1rNG7qy6i2kq+iBYir0oEM/toP02c74Oy5/ggctJQPDV8gN00/Ofva/ kNBXYTdcR5BlE33ZbE8AHMK2+Ggh0MJB1FpoZcYJlvlTYFfmPK3izDoA69l0zQCV2DaWeAak1e742 sHmKiJUQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGpPi-00FjsC-0h; Sun, 06 Feb 2022 21:49:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7D0FB300470; Sun, 6 Feb 2022 22:49:40 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 588002B37BEDA; Sun, 6 Feb 2022 22:49:40 +0100 (CET) Date: Sun, 6 Feb 2022 22:49:40 +0100 From: Peter Zijlstra To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@aculab.com, carlos@redhat.com, Peter Oskolkov , libc-coord@lists.openwall.com Subject: Re: [RFC PATCH 1/3] rseq: Introduce feature size and alignment ELF auxiliary vector entries Message-ID: References: <20220203193853.21511-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203193853.21511-1-mathieu.desnoyers@efficios.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 03, 2022 at 02:38:51PM -0500, Mathieu Desnoyers wrote: > @@ -286,6 +287,10 @@ create_elf_tables(struct linux_binprm *bprm, const struct elfhdr *exec, > if (bprm->have_execfd) { > NEW_AUX_ENT(AT_EXECFD, bprm->execfd); > } > +#ifdef CONFIG_RSEQ > + NEW_AUX_ENT(AT_RSEQ_FEATURE_SIZE, offsetof(struct rseq, end)); I've gotta ask, what's up with offsetof(, end) vs sizeof() ? > + NEW_AUX_ENT(AT_RSEQ_ALIGN, __alignof__(struct rseq)); > +#endif