From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E . McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
"H . Peter Anvin" <hpa@zytor.com>, Paul Turner <pjt@google.com>,
linux-api@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>,
Florian Weimer <fw@deneb.enyo.de>,
David.Laight@aculab.com, carlos@redhat.com,
Peter Oskolkov <posk@posk.io>,
libc-coord@lists.openwall.com
Subject: Re: [RFC PATCH 3/3] rseq: extend struct rseq with numa node id
Date: Sun, 6 Feb 2022 22:52:13 +0100 [thread overview]
Message-ID: <YgBDDVZSZqID8L3R@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220203193853.21511-3-mathieu.desnoyers@efficios.com>
On Thu, Feb 03, 2022 at 02:38:53PM -0500, Mathieu Desnoyers wrote:
> +static int rseq_reset_rseq_cpu_node_id(struct task_struct *t)
> {
> - u32 cpu_id_start = 0, cpu_id = RSEQ_CPU_ID_UNINITIALIZED;
> + u32 cpu_id_start = 0, cpu_id = RSEQ_CPU_ID_UNINITIALIZED, node_id = 0;
>
> /*
> * Reset cpu_id_start to its initial state (0).
> @@ -124,6 +126,11 @@ static int rseq_reset_rseq_cpu_id(struct task_struct *t)
> */
> if (put_user(cpu_id, &t->rseq->cpu_id))
> return -EFAULT;
> + /*
> + * Reset node_id to its initial state (0).
> + */
> + if (put_user(node_id, &t->rseq->node_id))
> + return -EFAULT;
Why 0 vs -1 ?
next prev parent reply other threads:[~2022-02-06 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 19:38 [RFC PATCH 1/3] rseq: Introduce feature size and alignment ELF auxiliary vector entries Mathieu Desnoyers
2022-02-03 19:38 ` [RFC PATCH 2/3] rseq: Introduce extensible rseq ABI Mathieu Desnoyers
2022-02-03 19:38 ` [RFC PATCH 3/3] rseq: extend struct rseq with numa node id Mathieu Desnoyers
2022-02-06 21:52 ` Peter Zijlstra [this message]
2022-02-07 16:39 ` Mathieu Desnoyers
2022-02-06 21:49 ` [RFC PATCH 1/3] rseq: Introduce feature size and alignment ELF auxiliary vector entries Peter Zijlstra
2022-02-06 23:53 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgBDDVZSZqID8L3R@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@aculab.com \
--cc=boqun.feng@gmail.com \
--cc=carlos@redhat.com \
--cc=christian.brauner@ubuntu.com \
--cc=fw@deneb.enyo.de \
--cc=hpa@zytor.com \
--cc=libc-coord@lists.openwall.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=pjt@google.com \
--cc=posk@posk.io \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox