From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FB6C4167B for ; Mon, 7 Feb 2022 10:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344571AbiBGKte (ORCPT ); Mon, 7 Feb 2022 05:49:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234981AbiBGKpE (ORCPT ); Mon, 7 Feb 2022 05:45:04 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D288C043181 for ; Mon, 7 Feb 2022 02:45:04 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 904F61EC0104; Mon, 7 Feb 2022 11:44:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644230698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=KKnX/UrcQAjdKahr0eOjhrQhxBDkbbbAzKZBK+b6hNI=; b=LtFpIuLpXhq61v7gcFUZqZ9W6CcXhEDo3jFiKdriZjaN5pu11RIjDJyiiBHhi5i+kGNX+C urF1Mjv7zpaQW1c78EdEdLYXU/VqbzIh2oNL+TMVyWKaNBXZbMTVJ5r/oS3DjOV46g4diK fAmIunBMv+5SybpBZWFC9EqdmOGToHk= Date: Mon, 7 Feb 2022 11:44:52 +0100 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@intel.com, luto@kernel.org, peterz@infradead.org, sathyanarayanan.kuppuswamy@linux.intel.com, aarcange@redhat.com, ak@linux.intel.com, dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com, jgross@suse.com, jmattson@google.com, joro@8bytes.org, jpoimboe@redhat.com, knsathya@kernel.org, pbonzini@redhat.com, sdeep@vmware.com, seanjc@google.com, tony.luck@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 20/29] x86/tdx: Get page shared bit info from the TDX module Message-ID: References: <20220124150215.36893-1-kirill.shutemov@linux.intel.com> <20220124150215.36893-21-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220124150215.36893-21-kirill.shutemov@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24, 2022 at 06:02:06PM +0300, Kirill A. Shutemov wrote: > @@ -59,6 +66,28 @@ long tdx_kvm_hypercall(unsigned int nr, unsigned long p1, unsigned long p2, > EXPORT_SYMBOL_GPL(tdx_kvm_hypercall); > #endif > > +static void tdx_get_info(void) Btw, can we strip the "tdx_" prefix off from all those static functions... there's an overload of "tdx" prefixes when looking at the code and it would be easier on the eyes if they're only with the external interfaces... it also helps differentiate which is which. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette