From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8DEC43219 for ; Mon, 7 Feb 2022 14:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382971AbiBGOnq (ORCPT ); Mon, 7 Feb 2022 09:43:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1441832AbiBGOdO (ORCPT ); Mon, 7 Feb 2022 09:33:14 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19948C0401C2 for ; Mon, 7 Feb 2022 06:33:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1A0D6137A for ; Mon, 7 Feb 2022 14:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B56C004E1; Mon, 7 Feb 2022 14:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644244393; bh=TD09Fo7V00ZrFPxmhD6nFW9qoDfKsYewzAmyIEgpbfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C0iOPuIswjiQZ0mlcK1SvXjuGfZ6csh4iWqFR0ZbTiuhem9VtvSmvwC4kLnfs6pAK SrXP2dnkWRoQ4phhHylFNOgdrczATRvB1nsLPD8EjJAwB5v8udEsh57vto/IIOtMlN aXaXgwJi74u6btc+yzAu+EtRN+DVqWzHnaBnT71c= Date: Mon, 7 Feb 2022 15:33:10 +0100 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Rodolfo Giometti , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver() Message-ID: References: <20220207141944.8707-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207141944.8707-1-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 07, 2022 at 04:19:44PM +0200, Andy Shevchenko wrote: > Switch to use module_parport_driver() to reduce boilerplate code. > > Signed-off-by: Andy Shevchenko > Acked-by: Rodolfo Giometti > --- > > v4: made sure the proper version is taken into consideration > v3: added Ack (Rodolfo), Cc'ed to Greg for picking it up > > drivers/pps/generators/pps_gen_parport.c | 42 ++++-------------------- > 1 file changed, 7 insertions(+), 35 deletions(-) > > diff --git a/drivers/pps/generators/pps_gen_parport.c b/drivers/pps/generators/pps_gen_parport.c > index 6a1af7664f3b..b3e084b75c23 100644 > --- a/drivers/pps/generators/pps_gen_parport.c > +++ b/drivers/pps/generators/pps_gen_parport.c > @@ -20,8 +20,6 @@ > #include > #include > > -#define DRVDESC "parallel port PPS signal generator" > - > #define SIGNAL 0 > #define NO_SIGNAL PARPORT_CONTROL_STROBE > > @@ -180,6 +178,11 @@ static void parport_attach(struct parport *port) > { > struct pardev_cb pps_cb; > > + if (send_delay > SEND_DELAY_MAX) { > + pr_err("delay value should be not greater then %d\n", SEND_DELAY_MAX); > + return; > + } > + > if (attached) { > /* we already have a port */ > return; > @@ -231,39 +234,8 @@ static struct parport_driver pps_gen_parport_driver = { > .detach = parport_detach, > .devmodel = true, > }; > - > -/* module staff */ > - > -static int __init pps_gen_parport_init(void) > -{ > - int ret; > - > - pr_info(DRVDESC "\n"); > - > - if (send_delay > SEND_DELAY_MAX) { > - pr_err("delay value should be not greater" > - " then %d\n", SEND_DELAY_MAX); > - return -EINVAL; > - } > - > - ret = parport_register_driver(&pps_gen_parport_driver); > - if (ret) { > - pr_err("unable to register with parport\n"); > - return ret; > - } > - > - return 0; > -} > - > -static void __exit pps_gen_parport_exit(void) > -{ > - parport_unregister_driver(&pps_gen_parport_driver); > - pr_info("hrtimer avg error is %ldns\n", hrtimer_error); > -} > - > -module_init(pps_gen_parport_init); > -module_exit(pps_gen_parport_exit); > +module_parport_driver(pps_gen_parport_driver); > > MODULE_AUTHOR("Alexander Gordeev "); > -MODULE_DESCRIPTION(DRVDESC); > +MODULE_DESCRIPTION("parallel port PPS signal generator"); > MODULE_LICENSE("GPL"); > -- > 2.34.1 > You changed the functionality here :( Currently if send_delay is too big, loading the module will fail. Now it succeeds but binding to a device fails, that's a functional change. Are you _SURE_ that is ok to do? And why did you not mention any of this in the changelog text? You passed this off as a mere code cleanup, no functional change :( thanks, greg k-h