Re: [PATCH v4 1/1] pps: generators: pps_gen_parport: Switch to use module_parport_driver()

Andy Shevchenko
2022-02-07T15:12:12Z

On Mon, Feb 07, 2022 at 03:33:10PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 07, 2022 at 04:19:44PM +0200, Andy Shevchenko wrote:
> > Switch to use module_parport_driver() to reduce boilerplate code.

> You changed the functionality here :(
>
> Currently if send_delay is too big, loading the module will fail.
>
> Now it succeeds but binding to a device fails, that's a functional
> change. Are you _SURE_ that is ok to do?

We already discussed that during v1 IIRC. And I told that it might even gain
additional flexibility for built-in case of the module.

> And why did you not mention any of this in the changelog text? You
> passed this off as a mere code cleanup, no functional change :(

This is fair point. Since we end up in the same Q above. I will update
changelog in v5.

Thank you for review!

--
With Best Regards,
Andy Shevchenko