Re: [PATCH v2 02/66] dt-bindings: interconnect: sunxi: Add V3s mbus compatible

Jernej Škrabec
2022-02-07T08:55:35Z

Hi Paul,

Dne ponedeljek, 07. februar 2022 ob 09:43:43 CET je Paul Kocialkowski
napisal(a):
> Hi,
>
> On Sat 05 Feb 22, 14:14, Samuel Holland wrote:
> > On 2/5/22 12:53 PM, Paul Kocialkowski wrote:
> > > Since the V3s uses the internal mbus, document its compatible.
> > >
> > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > > ---
> > >
> > > .../devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.
> > > yaml
> > > b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.
> > > yaml index 29c9961ee2d8..b67bf9261a6a 100644
> > > ---
> > > a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.
> > > yaml +++
> > > b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.
> > > yaml> >
> > > @@ -31,6 +31,7 @@ properties:
> > > - allwinner,sun5i-a13-mbus
> > > - allwinner,sun8i-h3-mbus
> > > - allwinner,sun8i-r40-mbus
> > >
> > > + - allwinner,sun8i-v3s-mbus
> >
> > Please enable the expanded binding added in commit 245578ba9f03
> > ("dt-bindings: arm: sunxi: Expand MBUS binding")[1] by adding the new
> > compatible to the "if" block lower in the file. That way we can add V3S
> > devfreq support in the future without changing that binding.
>
> I had missed that new driver but surely I will expand the updated binding.
>
> By the way do you have an explanation about the cell index given to the
> interconnects (after &mbus)?

This is mbus channel. You can find appropriate one checking DRAM driver in U-
Boot, where mbus is configured.

Best regards,
Jernej

>
> Paul
>
> > Regards,
> > Samuel
> >
> > [1]: https://git.kernel.org/torvalds/c/245578ba9f03
> >
> > > - allwinner,sun50i-a64-mbus
> > >