Re: [PATCH 08/23] KVM: MMU: rephrase unclear comment

David Matlack
2022-02-04T19:38:47Z

On Fri, Feb 04, 2022 at 06:57:03AM -0500, Paolo Bonzini wrote:
> If accessed bits are not supported there simple isn't any distinction
> between accessed and non-accessed gPTEs, so the comment does not make
> much sense. Rephrase it in terms of what happens if accessed bits
> *are* supported.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: David Matlack <dmatlack@google.com>

> ---
> arch/x86/kvm/mmu/paging_tmpl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h
> index 5b5bdac97c7b..6bb9a377bf89 100644
> --- a/arch/x86/kvm/mmu/paging_tmpl.h
> +++ b/arch/x86/kvm/mmu/paging_tmpl.h
> @@ -193,7 +193,7 @@ static bool FNAME(prefetch_invalid_gpte)(struct kvm_vcpu *vcpu,
> if (!FNAME(is_present_gpte)(gpte))
> goto no_present;
>
> - /* if accessed bit is not supported prefetch non accessed gpte */
> + /* if accessed bit is supported, prefetch only accessed gpte */
> if (PT_HAVE_ACCESSED_DIRTY(vcpu->arch.mmu) &&
> !(gpte & PT_GUEST_ACCESSED_MASK))
> goto no_present;
> --
> 2.31.1
>
>