Re: [PATCH 00/23] KVM: MMU: MMU role refactoring

Paolo Bonzini
2022-02-10T17:30:37Z

On 2/10/22 17:55, Sean Christopherson wrote:
>> union kvm_mmu_page_role root_role;
>> union kvm_mmu_paging_mode cpu_mode;
>
> I'd prefer to not use "paging mode", the SDM uses that terminology to refer to
> the four paging modes. My expectation given the name is that the union would
> track only CR0.PG, EFER.LME, CR4.PAE, and CR4.PSE[*].

Yeah, I had started with kvm_mmu_paging_flags, but cpu_flags was an even
worse method than kvm_mmu_paging_mode.

Anyway, now that I have done _some_ replacement, it's a matter of sed -i
on the patch files once you or someone else come up with a good moniker.

I take it that "root_role" passed your filter successfully.

Paolo

> I'm out of ideas at the moment, I'll keep chewing on this while reviewing...
>
> [*] Someone at Intel rewrote the SDM and eliminated Mode B, a.k.a. PSE 36-bit
> physical paging, it's now just part of "32-bit paging". But 5-level paging is
> considered it's own paging mode?!?! Lame. I guess they really want to have
> exactly four paging modes...