From: Stafford Horne <shorne@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Randy Dunlap <rdunlap@infradead.org>,
"openrisc@lists.librecores.org" <openrisc@lists.librecores.org>
Subject: Re: [PATCH] openrisc: remove CONFIG_SET_FS
Date: Tue, 8 Feb 2022 14:29:44 +0900 [thread overview]
Message-ID: <YgH/yC42RRbeJkiv@antec> (raw)
In-Reply-To: <3744dcbbf2874875b023548aacdd8b41@AcuMS.aculab.com>
On Mon, Feb 07, 2022 at 05:14:43PM +0000, David Laight wrote:
> From: Christoph Hellwig
> > Sent: 07 February 2022 06:45
> >
> > On Sun, Feb 06, 2022 at 10:36:47AM +0900, Stafford Horne wrote:
> > > Remove the address space override API set_fs() used for User Mode Linux.
> >
> > This ain't UML :)
> >
> > > + return size <= TASK_SIZE && addr <= (TASK_SIZE - size);
> >
> > No need for the inner braces.
>
> Since TASK_SIZE is actually an address wouldn't be better to
> swap the condition around (in every architecture).
>
> return addr <= TASK_SIZE && size <= TASK_SIZE - addr;
Hi David,
I like that, it is more clear, I will update to that in v3.
-Stafford
prev parent reply other threads:[~2022-02-08 5:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 1:36 [PATCH] openrisc: remove CONFIG_SET_FS Stafford Horne
2022-02-06 9:42 ` [OpenRISC] " Geert Uytterhoeven
2022-02-06 10:04 ` Stafford Horne
2022-02-07 6:45 ` Christoph Hellwig
2022-02-07 7:23 ` Stafford Horne
2022-02-07 17:14 ` David Laight
2022-02-08 5:29 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgH/yC42RRbeJkiv@antec \
--to=shorne@gmail.com \
--cc=David.Laight@aculab.com \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=rdunlap@infradead.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox