Re: [PATCH 1/4] platform/chrome: cros_ec_typec: Move mux flag checks

Tzung-Bi Shih
2022-02-08T05:41:49Z

On Mon, Feb 07, 2022 at 09:40:24PM +0000, Prashant Malani wrote:
> Move mux and role flag checks inside of cros_typec_configure_mux(),
> which is a more logical location for them.

nit: s/Move/Moves/.

> @@ -519,7 +519,14 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> struct cros_typec_port *port = typec->ports[port_num];
> struct ec_params_usb_pd_mux_ack mux_ack;
> enum typec_orientation orientation;
> - int ret;
> + int ret = 0;

The change looks irrelevant to the patch.