Re: [PATCH 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux

Prashant Malani
2022-02-08T06:04:42Z

On Mon, Feb 7, 2022 at 9:35 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> On Mon, Feb 07, 2022 at 09:40:26PM +0000, Prashant Malani wrote:
> > Move the function which gets current mux state inside the
> > cros_typec_configure_mux() function. It is better to group those
> > bits of functionality together, and it makes it easier to move around
> > cros_typec_configure_mux() later.
>
> nit: s/Move/Moves/.

Move is fine. Please see:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-your-changes

Quoting from the above: " Describe your changes in imperative mood,"

>
> > static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> > - uint8_t mux_flags,
> > struct ec_response_usb_pd_control_v2 *pd_ctrl)
> > {
> > struct cros_typec_port *port = typec->ports[port_num];
> > + struct ec_response_usb_pd_mux_info mux_resp;
> > + struct ec_params_usb_pd_mux_info req = {
> > + .port = port_num,
> > + };
> > struct ec_params_usb_pd_mux_ack mux_ack;
> > enum typec_orientation orientation;
> > int ret = 0;
> >
> > + ret = cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO,
> > + &req, sizeof(req), &mux_resp, sizeof(mux_resp));
>
> It was `req` and `resp` in cros_typec_get_mux_info(). However, `mux_resp` for
> separating from `struct ec_response_usb_pd_control_v2 resp` in
> cros_typec_port_update().
>
> It would be neat to be either {`req`, `resp`} or {`mux_req`, `mux_resp`} in
> cros_typec_configure_mux().

I'll change it to resp (instead of mux_resp)