Re: [PATCH] Fixed styleguide error by removing un-needed commented out lines

Re: [PATCH] Fixed styleguide error by removing un-needed commented out lines

[Greg KH]

On Mon, Feb 07, 2022 at 10:57:01PM +0530, Ankit Kumar Pandey wrote:
> Volatile keyword was left commented out as it was probably used during
> development but was not needed in final build.
> And this was causing styleguide error, so I have removed this and there
> are no warnings now.
> 
> Signed-off-by: Ankit Kumar Pandey <itsankitkp@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_pwrctrl.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.h b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
> index b35b9c792..29f8b6136 100644
> --- a/drivers/staging/rtl8712/rtl871x_pwrctrl.h
> +++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
> @@ -74,14 +74,14 @@ struct reportpwrstate_parm {
>  
>  struct	pwrctrl_priv {
>  	struct mutex mutex_lock;
> -	/*volatile*/ u8 rpwm; /* requested power state for fw */
> +	u8 rpwm; /* requested power state for fw */
>  	/* fw current power state. updated when 1. read from HCPWM or
>  	 * 2. driver lowers power level
>  	 */
> -	/*volatile*/ u8 cpwm;
> -	/*volatile*/ u8 tog; /* toggling */
> -	/*volatile*/ u8 cpwm_tog; /* toggling */
> -	/*volatile*/ u8 tgt_rpwm; /* wanted power state */
> +	u8 cpwm;
> +	u8 tog; /* toggling */
> +	u8 cpwm_tog; /* toggling */
> +	u8 tgt_rpwm; /* wanted power state */
>  	uint pwr_mode;
>  	uint smart_ps;
>  	uint alives;
> @@ -106,7 +106,7 @@ void r8712_unregister_cmd_alive(struct _adapter *padapter);
>  void r8712_cpwm_int_hdl(struct _adapter *padapter,
>  			struct reportpwrstate_parm *preportpwrstate);
>  void r8712_set_ps_mode(struct _adapter *padapter, uint ps_mode,
> -			uint smart_ps);
> +		       uint smart_ps);
>  void r8712_set_rpwm(struct _adapter *padapter, u8 val8);
>  void r8712_flush_rwctrl_works(struct _adapter *padapter);
>  
> -- 
> 2.32.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- You did not send this patch to the correct mailing list.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot