From: Tzung-Bi Shih <tzungbi@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
"open list:CHROMEOS EC USB TYPE-C DRIVER"
<chrome-platform@lists.linux.dev>
Subject: Re: [PATCH 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
Date: Tue, 8 Feb 2022 19:15:58 +0800 [thread overview]
Message-ID: <YgJQ7nvYivWozvdT@google.com> (raw)
In-Reply-To: <CACeCKafPyaT9-raroFh-UTunq93Yvh-uPb29oF9NbGZRZjv=Yw@mail.gmail.com>
On Mon, Feb 07, 2022 at 10:15:12PM -0800, Prashant Malani wrote:
> On Mon, Feb 7, 2022 at 9:38 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
> > On Mon, Feb 07, 2022 at 09:40:30PM +0000, Prashant Malani wrote:
> > > In cros_typec_remove_partner(), we call
> > > cros_typec_usb_disconnect_state() which sets the switches/muxes to be in
> > > a disconnected state. This also happens in cros_typec_configure_mux().
> > > However, unlike there, here the mux_flags variable hasn't been updated
> > > to reflect that a disconnection has occurred. Update the flag here
> > > accordingly.
> >
> > It is fine (at least to me) usually.
> >
> > Since you would need to respin the series anyway, s/Update/Updates/.
>
> Again, "update" is fine. Please see:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
>
> Quoting from the above: " Describe your changes in imperative mood,"
>
> So, imperative usage is actually preferred, and "updates/makes" is discouraged.
Ack, thanks for correcting my so-long-time misunderstanding.
prev parent reply other threads:[~2022-02-08 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 21:40 [PATCH 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-07 21:40 ` [PATCH 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
2022-02-08 5:33 ` Tzung-Bi Shih
2022-02-08 6:03 ` Prashant Malani
2022-02-07 21:40 ` [PATCH 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
2022-02-08 5:35 ` Tzung-Bi Shih
2022-02-08 6:04 ` Prashant Malani
2022-02-07 21:40 ` [PATCH 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
2022-02-08 5:38 ` Tzung-Bi Shih
2022-02-08 6:12 ` Prashant Malani
2022-02-08 11:15 ` Tzung-Bi Shih
2022-02-08 18:35 ` Prashant Malani
2022-02-08 22:58 ` Prashant Malani
2022-02-09 3:31 ` Tzung-Bi Shih
2022-02-09 3:41 ` Prashant Malani
2022-02-07 21:40 ` [PATCH 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
2022-02-08 5:38 ` Tzung-Bi Shih
2022-02-08 6:15 ` Prashant Malani
2022-02-08 11:15 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgJQ7nvYivWozvdT@google.com \
--to=tzungbi@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox