From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2] regmap-irq: Use regmap_irq_update_bits instead of regmap_write
Date: Tue, 8 Feb 2022 14:41:20 +0000 [thread overview]
Message-ID: <YgKBEIapL8MAQAoI@sirena.org.uk> (raw)
In-Reply-To: <20220208143316.GE112838@ediswmail.ad.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Tue, Feb 08, 2022 at 02:33:16PM +0000, Charles Keepax wrote:
> On Tue, Feb 08, 2022 at 01:56:20PM +0000, Mark Brown wrote:
> > My understanding was that they'd mixed interrupt handling in as a
> > bitfield in another register.
> Eek.. what a courageous choice. I guess that might work as
> long as there is only a single IRQ status bit in the register,
> if there are multiple bits this really needs more complex
> handling, like you basically need the old behaviour for the
> IRQ part of the register, and the new behaviour for the not
> IRQ part of the register. So perhaps a new mask to denote which
> bit of the register is being used for IRQ stuff?
Yeah, I think that's what I misread the code as doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-08 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220208122955eucas1p2d4e32f51224242e9ebd0bce58b9c04ca@eucas1p2.samsung.com>
2022-01-19 14:29 ` [PATCH v2] regmap-irq: Use regmap_irq_update_bits instead of regmap_write Prasad Kumpatla
2022-02-03 12:52 ` Mark Brown
2022-02-08 12:29 ` Marek Szyprowski
2022-02-08 13:39 ` Charles Keepax
2022-02-08 13:50 ` Charles Keepax
2022-02-08 13:56 ` Mark Brown
2022-02-08 14:33 ` Charles Keepax
2022-02-08 14:41 ` Mark Brown [this message]
[not found] ` <22d9bf04-e069-c6a3-4d59-974a9402b0f7@quicinc.com>
2022-02-15 10:54 ` Charles Keepax
2022-02-08 13:44 ` Mark Brown
2022-02-09 8:41 ` Prasad Kumpatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgKBEIapL8MAQAoI@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox