From: Tzung-Bi Shih <tzungbi@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
"open list:CHROMEOS EC USB TYPE-C DRIVER"
<chrome-platform@lists.linux.dev>
Subject: Re: [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
Date: Wed, 9 Feb 2022 11:32:28 +0800 [thread overview]
Message-ID: <YgM1zM7Vpn/FlHv7@google.com> (raw)
In-Reply-To: <20220208184721.1697194-5-pmalani@chromium.org>
On Tue, Feb 08, 2022 at 06:47:24PM +0000, Prashant Malani wrote:
> In cros_typec_remove_partner(), we call
> cros_typec_usb_disconnect_state() which sets the switches/muxes to be in
> a disconnected state. This also happens in cros_typec_configure_mux().
> However, unlike there, here the mux_flags variable hasn't been updated
> to reflect that a disconnection has occurred. Update the flag here
> accordingly.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
next prev parent reply other threads:[~2022-02-09 4:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
2022-02-15 0:27 ` Benson Leung
2022-02-08 18:47 ` [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih [this message]
2022-02-15 20:00 ` [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration patchwork-bot+chrome-platform
2022-02-16 22:00 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgM1zM7Vpn/FlHv7@google.com \
--to=tzungbi@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox