From: Rob Herring <robh@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCHv2] dt-bindings: clock: Add binding for TI clksel
Date: Wed, 9 Feb 2022 16:01:02 -0600 [thread overview]
Message-ID: <YgQ5no/7cEW4yRrM@robh.at.kernel.org> (raw)
In-Reply-To: <20220203073929.59296-1-tony@atomide.com>
On Thu, 03 Feb 2022 09:39:29 +0200, Tony Lindgren wrote:
> In order to prepare for fixing lots of devicetree unique_unit_address
> warnings for the TI clock nodes, let's add a binding for the TI clksel
> clocks. This allows us to move the overlapping reg properties for the
> component clocks to be children of the related clksel nodes. And with
> that we need the reg property only for the parent clksel node making
> the reg property unique like it should be.
>
> We want to set #clock-cells = <2> in case we ever start parsing ranges
> of clkcsel instances directly using a clksel driver rather than using the
> existing component clock drivers and child nodes.
>
> And before the devicetree files can be updated, we need to update the
> TI clock drivers to get the IO address from the parent clksel node.
>
> Cc: Tero Kristo <kristo@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>
> Changes since V1:
>
> - Set additionalProperties to type object as suggested by Rob
>
> - Changed #clock-cells to 2 for parsing ranges of clksel instances
>
> - Updated patch description for more info on why this is needed
>
> .../bindings/clock/ti/ti,clksel.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clksel.yaml
>
Applied, thanks!
prev parent reply other threads:[~2022-02-09 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 7:39 [PATCHv2] dt-bindings: clock: Add binding for TI clksel Tony Lindgren
2022-02-09 22:01 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgQ5no/7cEW4yRrM@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox