From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Satya Priya <quic_c_skakit@quicinc.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Das Srinagesh <gurus@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
quic_collinsd@quicinc.com, quic_subbaram@quicinc.com,
quic_jprakash@quicinc.com
Subject: Re: [PATCH V5 4/6] regulator: Add a regulator driver for the PM8008 PMIC
Date: Thu, 10 Feb 2022 18:57:58 -0600 [thread overview]
Message-ID: <YgW0ltMKjGZH4NrZ@builder.lan> (raw)
In-Reply-To: <1644331940-18986-5-git-send-email-quic_c_skakit@quicinc.com>
On Tue 08 Feb 08:52 CST 2022, Satya Priya wrote:
> diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c
[..]
> +static int pm8008_regulator_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + int id = pdev->id % PM8008_NUM_LDOS;
Why does this driver look completely different from all the other
Qualcomm regulator drivers that we already have, and why do you register
one platform_device per regulator?
The fundamental difference in design makes it hard to maintain and
you're wasting quite a bit of memory with the unnecessary
platfrom_device objects.
Regards,
Bjorn
next prev parent reply other threads:[~2022-02-11 0:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:52 [PATCH V5 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-02-08 14:52 ` [PATCH V5 1/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2022-02-09 18:49 ` Rob Herring
2022-02-10 1:24 ` Stephen Boyd
2022-02-11 10:01 ` Satya Priya Kakitapalli (Temp)
2022-02-11 0:43 ` Bjorn Andersson
2022-02-11 10:23 ` Satya Priya Kakitapalli (Temp)
2022-02-08 14:52 ` [PATCH V5 2/6] dt-bindings: mfd: pm8008: Add regulators node Satya Priya
2022-02-09 18:51 ` Rob Herring
2022-02-08 14:52 ` [PATCH V5 3/6] mfd: pm8008: Add mfd cell struct to register LDOs Satya Priya
2022-02-10 1:32 ` Stephen Boyd
2022-02-11 10:12 ` Satya Priya Kakitapalli (Temp)
2022-02-11 13:34 ` Lee Jones
2022-02-11 15:11 ` Satya Priya Kakitapalli (Temp)
2022-02-08 14:52 ` [PATCH V5 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-02-09 14:18 ` Mark Brown
2022-02-11 10:00 ` Satya Priya Kakitapalli (Temp)
2022-02-10 1:40 ` Stephen Boyd
2022-02-11 0:57 ` Bjorn Andersson [this message]
2022-02-11 10:35 ` Satya Priya Kakitapalli (Temp)
2022-02-11 11:01 ` Matti Vaittinen
2022-02-11 14:48 ` Satya Priya Kakitapalli (Temp)
2022-02-08 14:52 ` [PATCH V5 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-02-10 1:41 ` Stephen Boyd
2022-02-11 10:22 ` Satya Priya Kakitapalli (Temp)
2022-02-08 14:52 ` [PATCH V5 6/6] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgW0ltMKjGZH4NrZ@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox