From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7654FC433F5 for ; Fri, 11 Feb 2022 00:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346611AbiBKA6D (ORCPT ); Thu, 10 Feb 2022 19:58:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346610AbiBKA6B (ORCPT ); Thu, 10 Feb 2022 19:58:01 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B95115D for ; Thu, 10 Feb 2022 16:58:01 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id v67so7906946oie.9 for ; Thu, 10 Feb 2022 16:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RIcE6EmL7kT/dbMWMgTFXFCKl5OtURzfiDQZ4YFPwds=; b=c0nucwE2xmQBr21axX4FFbLOpIRgjRGCMcnOmviW8SfXcV0MIYgerZvSMw00UtcUH+ DKwVSXzc7bHC9eabpjlOR3YafNwlzMeeCuYqW4DIhsHwQ9PNt/ySayGQFJgtNBp8Qllf k6V5MaLIgQ0883h0v5quCPZlC0P+ezMHFqHkHZpE1itBoZHWIh8j5zypSwlJy1yNbnhw XSU+b0LcSH29qyCwFH7xpmPC5qOwV2H2CQN6FNU5c5buVTL1MddVLuE4JMfqm59rUTIn YTMNb/kllBxb6C+V3PmUlye9yRUevUeg9pyHcYToARwvGhajpfV6yWN0/ETyo9xE6bUs 2iBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RIcE6EmL7kT/dbMWMgTFXFCKl5OtURzfiDQZ4YFPwds=; b=QS0NekAp6zs0INLiXRLcXlxEXAPLezLlzRpGr8amgzQsbGraTKQ1tdVBdyyQjie6U4 3D17m1FTi18S7mIZ5EV5Z7cx0M4GMANnZ/9hI3uKJA4zpZyFy2mHiAFGn+rsly70l6ac DTkEg3zoZ7dX2RiK3XN2IIAdVGkozFlJr5mN2qc1YpycCv6HnVS8lXcq+tgNwDc5i94q qisT2klBcZZdqHTYg3dg2DyI1g0nHZFxuLKpZk8peVbtbUK5sx7W6zbLpj180YN56Pga tGwGH+K4EufsLLMVxXOVafCxhJCSBZzH4/Bn++/ObkDArRtULgkP2PA5G0vxxl9MMxGO PzVA== X-Gm-Message-State: AOAM532pQO4FUEeof5lyuXhnR9V8K0h4V0b+Brpaks/UAjTmkrFzF0Jn DNbhuH1sn93lOnVcKWgX2PN8lA== X-Google-Smtp-Source: ABdhPJzt0YDFqxhTffnmhdr/b/vh0d8iWDbPSGBr8z41W2djZIWe6uU1n0Gw1hxK2wnNZATT9yiNLA== X-Received: by 2002:a05:6808:1058:: with SMTP id c24mr27497oih.257.1644541081190; Thu, 10 Feb 2022 16:58:01 -0800 (PST) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id n9sm8331308otf.9.2022.02.10.16.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 16:58:00 -0800 (PST) Date: Thu, 10 Feb 2022 18:57:58 -0600 From: Bjorn Andersson To: Satya Priya Cc: Rob Herring , Krzysztof Kozlowski , Lee Jones , Liam Girdwood , Mark Brown , Das Srinagesh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_jprakash@quicinc.com Subject: Re: [PATCH V5 4/6] regulator: Add a regulator driver for the PM8008 PMIC Message-ID: References: <1644331940-18986-1-git-send-email-quic_c_skakit@quicinc.com> <1644331940-18986-5-git-send-email-quic_c_skakit@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1644331940-18986-5-git-send-email-quic_c_skakit@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 08 Feb 08:52 CST 2022, Satya Priya wrote: > diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c [..] > +static int pm8008_regulator_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + int id = pdev->id % PM8008_NUM_LDOS; Why does this driver look completely different from all the other Qualcomm regulator drivers that we already have, and why do you register one platform_device per regulator? The fundamental difference in design makes it hard to maintain and you're wasting quite a bit of memory with the unnecessary platfrom_device objects. Regards, Bjorn